Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 9232033: Do not set checked mode unconditionally for Dartium (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add corresponding change to test.dart side. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tools/testing/architecture.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #library("test_suite"); 5 #library("test_suite");
6 6
7 #import("status_file_parser.dart"); 7 #import("status_file_parser.dart");
8 #import("test_runner.dart"); 8 #import("test_runner.dart");
9 #import("multitest.dart"); 9 #import("multitest.dart");
10 10
(...skipping 449 matching lines...) Expand 10 before | Expand all | Expand 10 after
460 460
461 String executable = getFilename(dumpRenderTreeFilename); 461 String executable = getFilename(dumpRenderTreeFilename);
462 List<String> args; 462 List<String> args;
463 if (component == 'webdriver') { 463 if (component == 'webdriver') {
464 // TODO(efortuna): These paths are not OS independent! 464 // TODO(efortuna): These paths are not OS independent!
465 executable = '$dartDir/tools/testing/run_selenium.py'; 465 executable = '$dartDir/tools/testing/run_selenium.py';
466 args = ['--out', htmlPath, '--browser', configuration['browser']]; 466 args = ['--out', htmlPath, '--browser', configuration['browser']];
467 } else { 467 } else {
468 args = ['--no-timeout']; 468 args = ['--no-timeout'];
469 if (component == 'dartium') { 469 if (component == 'dartium') {
470 var dartFlags = ['--enable_asserts', 470 var dartFlags = ['--ignore-unrecognized-flags'];
471 '--enable_type_checks', 471 if (configuration["checked"]) {
472 '--ignore-unrecognized-flags']; 472 dartFlags.add('--enable_asserts');
473 dartFlags.add("--enable_type_checks");
474 }
473 dartFlags.addAll(vmOptions); 475 dartFlags.addAll(vmOptions);
474 args.add('--dart-flags=${Strings.join(dartFlags, " ")}'); 476 args.add('--dart-flags=${Strings.join(dartFlags, " ")}');
475 } 477 }
476 args.add(htmlPath); 478 args.add(htmlPath);
477 } 479 }
478 // Create BrowserTestCase and queue it. 480 // Create BrowserTestCase and queue it.
479 var testCase = new BrowserTestCase( 481 var testCase = new BrowserTestCase(
480 testName, 482 testName,
481 compilerExecutable, 483 compilerExecutable,
482 compilerArgs, 484 compilerArgs,
(...skipping 551 matching lines...) Expand 10 before | Expand all | Expand 10 after
1034 * $noCrash tests are expected to be flaky but not crash 1036 * $noCrash tests are expected to be flaky but not crash
1035 * $pass tests are expected to pass 1037 * $pass tests are expected to pass
1036 * $failOk tests are expected to fail that we won't fix 1038 * $failOk tests are expected to fail that we won't fix
1037 * $fail tests are expected to fail that we should fix 1039 * $fail tests are expected to fail that we should fix
1038 * $crash tests are expected to crash that we should fix 1040 * $crash tests are expected to crash that we should fix
1039 * $timeout tests are allowed to timeout 1041 * $timeout tests are allowed to timeout
1040 """; 1042 """;
1041 print(report); 1043 print(report);
1042 } 1044 }
1043 } 1045 }
OLDNEW
« no previous file with comments | « tools/testing/architecture.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698