Improve function compilation times for swarm application startup.

vm/object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_OBJECT_H_
 #define VM_OBJECT_H_
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/utils.h"
@@ skipping 2615 matching lines @@
   static intptr_t hash_offset() { return OFFSET_OF(RawString, hash_); }
   static intptr_t Hash(const String& str, intptr_t begin_index, intptr_t len);
   static intptr_t Hash(const uint8_t* characters, intptr_t len);
   static intptr_t Hash(const uint16_t* characters, intptr_t len);
   static intptr_t Hash(const uint32_t* characters, intptr_t len);
 
   virtual int32_t CharAt(intptr_t index) const;
 
   virtual intptr_t CharSize() const;
 
+  bool Equals(const String& str) const {
+    if (raw() == str.raw()) {
+      return true;  // Both handles point to the same raw instance.
+    }
+    if (str.IsNull()) {
+      return false;
+    }

[Ivan Posva, 2012/01/18 19:44:30]

Do you want to inline the hash check here?

[siva, 2012/01/18 20:01:06]

As discussed offline, introducing the hash check seems to degrade performance. I
think additional checks introduced do not pay off enough.

On 2012/01/18 19:44:30, Ivan Posva wrote:

+    return Equals(str, 0, str.Length());
+  }
   bool Equals(const String& str, intptr_t begin_index, intptr_t len) const;
   bool Equals(const char* str) const;
   bool Equals(const uint8_t* characters, intptr_t len) const;
   bool Equals(const uint16_t* characters, intptr_t len) const;
   bool Equals(const uint32_t* characters, intptr_t len) const;
 
   virtual bool Equals(const Instance& other) const;
 
   intptr_t CompareTo(const String& other) const;
 
@@ skipping 794 matching lines @@
 }
 
 
 void Context::SetAt(intptr_t index, const Instance& value) const {
   StorePointer(InstanceAddr(index), value.raw());
 }
 
 }  // namespace dart
 
 #endif  // VM_OBJECT_H_