Issue 9232008: Fixing ChromeOS File Browser test harness.

Issue 9232008: Fixing ChromeOS File Browser test harness. (Closed)

Created:
8 years, 11 months ago by Vladislav Kaznacheev

Modified:
8 years, 11 months ago

Reviewers:
dgozman, SeRya

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixing ChromeOS File Browser test harness. Instead of relying on an obsolete --unlimited-quota-for-files switch the harness now properly requests a local file system quota. BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=117888

Patch Set 1 #

Total comments: 4

Patch Set 2 : Comments addressed #

Patch Set 3 : Copyright fix #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -9 lines)			Patch
	M	chrome/browser/resources/file_manager/README.harness	View	1	1 chunk	+7 lines, -2 lines	0 comments	Download
	M	chrome/browser/resources/file_manager/js/harness.js	View	1 2	4 chunks	+15 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dgozman

LGTM http://codereview.chromium.org/9232008/diff/1/chrome/browser/resources/file_manager/README.harness File chrome/browser/resources/file_manager/README.harness (right): http://codereview.chromium.org/9232008/diff/1/chrome/browser/resources/file_manager/README.harness#newcode19 chrome/browser/resources/file_manager/README.harness:19: "Open File" dialog is displayed by default. You ...

8 years, 11 months ago (2012-01-17 12:10:09 UTC) #2

Vladislav Kaznacheev

Thanks for the review. Committing. http://codereview.chromium.org/9232008/diff/1/chrome/browser/resources/file_manager/README.harness File chrome/browser/resources/file_manager/README.harness (right): http://codereview.chromium.org/9232008/diff/1/chrome/browser/resources/file_manager/README.harness#newcode19 chrome/browser/resources/file_manager/README.harness:19: "Open File" dialog is ...

8 years, 11 months ago (2012-01-17 12:44:29 UTC) #3

commit-bot: I haz the power

8 years, 11 months ago (2012-01-17 12:44:39 UTC) #4

No LGTM from any valid reviewer yet. Even if a LGTM may have been
provided, it was from a non-committer or a provisional committer
and not a full committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Expand Messages | Collapse Messages