test/cctest/test-strings.cc - Issue 9231017: Recursion limit for one-char string replace and retire String::kMinNonFlatLength.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-strings.cc

Issue 9231017: Recursion limit for one-char string replace and retire String::kMinNonFlatLength. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-strings.cc

diff --git a/test/cctest/test-strings.cc b/test/cctest/test-strings.cc

index 93f7588d3617bf69122e3b985898792c72ce23e2..e11349bc85a6ce4f4bed22793fffb5007dea3014 100644

--- a/test/cctest/test-strings.cc

+++ b/test/cctest/test-strings.cc

@@ -355,7 +355,7 @@ TEST(ExternalShortStringAdd) {

// Make sure we cover all always-flat lengths and at least one above.

static const int kMaxLength = 20;

- CHECK_GT(kMaxLength, i::String::kMinNonFlatLength);

+ CHECK_GT(kMaxLength, i::ConsString::kMinLength);

// Allocate two JavaScript arrays for holding short strings.

v8::Handle<v8::Array> ascii_external_strings =

« src/string.js ('K') | « src/x64/code-stubs-x64.cc ('k') | test/mjsunit/string-replace-one-char.js » ('j') | test/mjsunit/string-replace-one-char.js » ('J')