Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 9230004: Remove API elements that are no longer in the IME API design document (Closed)

Created:
8 years, 11 months ago by Zachary Kuznia
Modified:
8 years, 11 months ago
Reviewers:
Yusuke Sato, Matt Perry
CC:
chromium-reviews, nkostylev+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Remove API elements that are no longer in the IME API design document R=yusukes@chromium.org BUG=chromium-os:23639 TEST=Run the API tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118047

Patch Set 1 #

Patch Set 2 : Fix copyright #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -104 lines) Patch
M chrome/browser/chromeos/input_method/input_method_engine.h View 1 5 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine.cc View 1 7 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_input_ime_api.cc View 1 6 chunks +2 lines, -52 lines 0 comments Download
M chrome/browser/extensions/extension_input_module_constants.h View 1 4 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/extensions/extension_input_module_constants.cc View 1 4 chunks +1 line, -6 lines 0 comments Download
M chrome/common/extensions/api/experimental.input.ime.json View 3 chunks +2 lines, -27 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Zachary Kuznia
8 years, 11 months ago (2012-01-16 07:46:28 UTC) #1
Zachary Kuznia
On 2012/01/16 07:46:28, Zachary Kuznia wrote: Matt, could you review the change to chrome/common/extensions/api/experimental.input.ime.json? Thanks, ...
8 years, 11 months ago (2012-01-16 07:47:25 UTC) #2
Yusuke Sato
LGTM On 2012/01/16 07:47:25, Zachary Kuznia wrote: > On 2012/01/16 07:46:28, Zachary Kuznia wrote: > ...
8 years, 11 months ago (2012-01-17 05:47:02 UTC) #3
Matt Perry
8 years, 11 months ago (2012-01-17 19:30:27 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698