Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: webkit/support/webkit_support.cc

Issue 9226036: Refactor WebGraphicsContext3DInProcess and TestWebGraphicsContext3D (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix windows build Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/support/test_webkit_platform_support.cc ('k') | webkit/tools/test_shell/test_shell_webkit_init.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/support/webkit_support.cc
diff --git a/webkit/support/webkit_support.cc b/webkit/support/webkit_support.cc
index 802a51e4e8b46d136690fc8629d71c8bb3c3286a..516a28ea253262ccae60e64ecb10ce46b3577c0a 100644
--- a/webkit/support/webkit_support.cc
+++ b/webkit/support/webkit_support.cc
@@ -74,6 +74,8 @@ using WebKit::WebPlugin;
using WebKit::WebPluginParams;
using WebKit::WebString;
using WebKit::WebURL;
+using webkit::gpu::WebGraphicsContext3DInProcessImpl;
+using webkit::gpu::WebGraphicsContext3DInProcessCommandBufferImpl;
namespace {
@@ -372,20 +374,20 @@ WebKit::WebGraphicsContext3D* CreateGraphicsContext3D(
const WebKit::WebGraphicsContext3D::Attributes& attributes,
WebKit::WebView* web_view,
bool direct) {
- scoped_ptr<WebKit::WebGraphicsContext3D> context;
switch (webkit_support::GetGraphicsContext3DImplementation()) {
case webkit_support::IN_PROCESS:
- context.reset(new webkit::gpu::WebGraphicsContext3DInProcessImpl(
- gfx::kNullPluginWindow, NULL));
- break;
- case webkit_support::IN_PROCESS_COMMAND_BUFFER:
- context.reset(
- new webkit::gpu::WebGraphicsContext3DInProcessCommandBufferImpl());
- break;
+ return WebGraphicsContext3DInProcessImpl::CreateForWebView(
+ attributes, web_view, direct);
+ case webkit_support::IN_PROCESS_COMMAND_BUFFER: {
+ scoped_ptr<WebGraphicsContext3DInProcessCommandBufferImpl> context(
+ new WebGraphicsContext3DInProcessCommandBufferImpl());
+ if (!context->initialize(attributes, web_view, direct))
+ return NULL;
+ return context.release();
+ }
}
- if (!context->initialize(attributes, web_view, direct))
- return NULL;
- return context.release();
+ NOTREACHED();
+ return NULL;
}
void RegisterMockedURL(const WebKit::WebURL& url,
« no previous file with comments | « webkit/support/test_webkit_platform_support.cc ('k') | webkit/tools/test_shell/test_shell_webkit_init.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698