Issue 9226024: aura_builder target needs to work on Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9226024: aura_builder target needs to work on Mac (Closed)

Created:
8 years, 11 months ago by dhollowa

Modified:
8 years, 11 months ago

Reviewers:
cmp, oshima

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

aura_builder target needs to work on Mac Extends 'aura_builder' target to work on Mac. This excludes bits that are not currently working. To build: ash_shell aura_demo aura_unittests compositor_unittests To run: compositor_unittests webkit_unit_tests Gyp flags: 'use_aura': 1 BUG=110632, 110627 TEST=Compile 'aura_builder' target on Mac with 'use_aura' bit set. R=cmp@chromium.org, oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118535

Patch Set 1 #

Total comments: 2

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	ash/wm/window_modality_controller_unittest.cc	View		1 chunk	+1 line, -1 line	2 comments	Download
	M	build/all.gyp	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

oshima

lgtm https://chromiumcodereview.appspot.com/9226024/diff/1/ash/wm/window_modality_controller_unittest.cc File ash/wm/window_modality_controller_unittest.cc (right): https://chromiumcodereview.appspot.com/9226024/diff/1/ash/wm/window_modality_controller_unittest.cc#newcode148 ash/wm/window_modality_controller_unittest.cc:148: } // namespace ash is this intentional?

8 years, 11 months ago (2012-01-20 21:10:08 UTC) #3

dhollowa

8 years, 11 months ago (2012-01-20 21:13:33 UTC) #4

https://chromiumcodereview.appspot.com/9226024/diff/1/ash/wm/window_modality_...
File ash/wm/window_modality_controller_unittest.cc (right):

https://chromiumcodereview.appspot.com/9226024/diff/1/ash/wm/window_modality_...
ash/wm/window_modality_controller_unittest.cc:148: }  // namespace ash
On 2012/01/20 21:10:08, oshima wrote:
> is this intentional?

Yes, clang issues warnings for missing newlines.

Expand Messages | Collapse Messages