Add a blocking version of the sync promo dialog

chrome/browser/ui/webui/sync_setup_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/sync_setup_handler.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
@@ skipping 204 matching lines @@
       "passphraseEncryptionMessage",
       GetStringFUTF16(IDS_SYNC_PASSPHRASE_ENCRYPTION_MESSAGE, product_name));
   localized_strings->SetString(
       "passphraseRecover",
       GetStringFUTF16(IDS_SYNC_PASSPHRASE_RECOVER,
                       ASCIIToUTF16(google_util::StringAppendGoogleLocaleParam(
                           chrome::kSyncGoogleDashboardURL))));
 
   bool is_launch_page = web_ui && SyncPromoUI::GetIsLaunchPageForSyncPromoURL(
       web_ui->GetWebContents()->GetURL());
-  int title_id = is_launch_page ? IDS_SYNC_PROMO_TITLE :
+  int title_id = is_launch_page ? IDS_SYNC_PROMO_TITLE_SHORT :

[Dan Beam, 2012/01/30 18:10:05]

where did this change? did this value already exist?

[sail, 2012/01/30 21:52:36]

yea, this value already existed, I was using the wrong one here

                                   IDS_SYNC_PROMO_TITLE_EXISTING_USER;
   string16 short_product_name(GetStringUTF16(IDS_SHORT_PRODUCT_NAME));
   localized_strings->SetString(
       "promoTitle", GetStringFUTF16(title_id, short_product_name));
 
   localized_strings->SetString(
       "promoMessageTitle",
       GetStringFUTF16(IDS_SYNC_PROMO_MESSAGE_TITLE, short_product_name));
   localized_strings->SetString(
       "syncEverythingHelpURL", chrome::kSyncEverythingLearnMoreURL);
@@ skipping 429 matching lines @@
   return true;
 }
 
 void SyncSetupHandler::ShowLoginErrorMessage(const string16& error_message) {
   DCHECK(flow_);
   DictionaryValue args;
   flow_->GetArgsForGaiaLogin(&args);
   args.SetString("error_message", error_message);
   ShowGaiaLogin(args);
 }