runtime/bin/file_impl.dart - Issue 9225019: Fix race condition between signal handler and main thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/file_impl.dart

Issue 9225019: Fix race condition between signal handler and main thread. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/file_impl.dart

diff --git a/runtime/bin/file_impl.dart b/runtime/bin/file_impl.dart

index b3691606c0638c469f123f86cf7c37fdddb500b7..8cc8745113605a4fd15c3e5689cff98bb527681a 100644

--- a/runtime/bin/file_impl.dart

+++ b/runtime/bin/file_impl.dart

@@ -690,7 +690,7 @@ class _RandomAccessFile implements RandomAccessFile {

void close() {

_asyncUsed = true;

var handler = (_closeHandler != null) ? _closeHandler : () => null;

- var handleOpenResult = (result, ignored) {

+ var handleCloseResult = (result, ignored) {

if (result != -1) {

_id = result;

handler();

@@ -699,7 +699,7 @@ class _RandomAccessFile implements RandomAccessFile {

}

};

var operation = new _CloseOperation(_id);

- _scheduler.enqueue(operation, handleOpenResult);

+ _scheduler.enqueue(operation, handleCloseResult);

}

void closeSync() {

« no previous file with comments | « runtime/bin/fdutils_macos.cc ('k') | runtime/bin/process_linux.cc » ('j') | no next file with comments »