chrome/browser/extensions/extension_javascript_url_apitest.cc - Issue 9225010: Fix callback for chrome.tabs.update with javascript URLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_javascript_url_apitest.cc

Issue 9225010: Fix callback for chrome.tabs.update with javascript URLs. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: nits Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_javascript_url_apitest.cc

diff --git a/chrome/browser/extensions/extension_javascript_url_apitest.cc b/chrome/browser/extensions/extension_javascript_url_apitest.cc

index d7ea29e78ab579a31957d12097a68562ae52de81..854e01638dc9f3a954b89b6262b8d1f44b57a0ff 100644

--- a/chrome/browser/extensions/extension_javascript_url_apitest.cc

+++ b/chrome/browser/extensions/extension_javascript_url_apitest.cc

@@ -5,8 +5,8 @@

#include "chrome/browser/extensions/extension_apitest.h"

#include "net/base/mock_host_resolver.h"

-// Disabled, http://crbug.com/63589.

-IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_JavaScriptURLPermissions) {

+// If crashing, mark disabled and update http://crbug.com/63589.

+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, JavaScriptURLPermissions) {

host_resolver()->AddRule("a.com", "127.0.0.1");

host_resolver()->AddRule("b.com", "127.0.0.1");

ASSERT_TRUE(StartTestServer());