Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2428)

Unified Diff: content/public/browser/web_contents.h

Issue 9224002: Make WebUI objects not derive from WebUI. WebUI objects own the controller. This is the ownership... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync to head to clear linux_chromeos browsertest failures Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents.h
===================================================================
--- content/public/browser/web_contents.h (revision 117871)
+++ content/public/browser/web_contents.h (working copy)
@@ -109,6 +109,12 @@
// The TabContentsView will never change and is guaranteed non-NULL.
virtual TabContentsView* GetView() const = 0;
+ // Create a WebUI page for the given url. In most cases, this doesn't need to
+ // be called by embedders since content will create its own WebUI objects as
+ // necessary. However if the embedder wants to create its own WebUI object and
+ // keep track of it manually, it can use this.
+ virtual WebUI* CreateWebUI(const GURL& url) = 0;
+
// Returns the committed WebUI if one exists, otherwise the pending one.
// Callers who want to use the pending WebUI for the pending navigation entry
// should use GetWebUIForCurrentState instead.

Powered by Google App Engine
This is Rietveld 408576698