Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2115)

Unified Diff: content/browser/tab_contents/tab_contents_unittest.cc

Issue 9224002: Make WebUI objects not derive from WebUI. WebUI objects own the controller. This is the ownership... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync to head to clear linux_chromeos browsertest failures Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tab_contents/tab_contents_unittest.cc
===================================================================
--- content/browser/tab_contents/tab_contents_unittest.cc (revision 117871)
+++ content/browser/tab_contents/tab_contents_unittest.cc (working copy)
@@ -30,19 +30,19 @@
using content::NavigationEntry;
using content::NavigationEntryImpl;
using content::WebContents;
+using content::WebUIController;
using webkit::forms::PasswordForm;
namespace {
class TabContentsTestWebUIFactory : public content::EmptyWebUIFactory {
public:
- virtual WebUI* CreateWebUIForURL(WebContents* source,
- const GURL& url) const OVERRIDE {
+ virtual WebUIController* CreateWebUIForURL(WebUI* web_ui,
+ const GURL& url) const OVERRIDE {
if (!HasWebUIScheme(url))
return NULL;
- static content::WebUIController temp_controller;
- return new WebUI(source, &temp_controller);
+ return new WebUIController(web_ui);
}
virtual bool UseWebUIForURL(content::BrowserContext* browser_context,
@@ -58,7 +58,6 @@
const GURL& url) const {
return HasWebUIScheme(url);
}
-
};
class TabContentsTestBrowserClient : public content::MockContentBrowserClient {

Powered by Google App Engine
This is Rietveld 408576698