Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Side by Side Diff: chrome/browser/ui/webui/uber/uber_ui.h

Issue 9224002: Make WebUI objects not derive from WebUI. WebUI objects own the controller. This is the ownership... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync to head to clear linux_chromeos browsertest failures Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_UBER_UBER_UI_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_UBER_UBER_UI_H_
6 #define CHROME_BROWSER_UI_WEBUI_UBER_UBER_UI_H_ 6 #define CHROME_BROWSER_UI_WEBUI_UBER_UBER_UI_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
11 #include "base/memory/scoped_vector.h" 11 #include "base/memory/scoped_vector.h"
12 #include "base/values.h" 12 #include "base/values.h"
13 #include "content/browser/webui/web_ui.h"
14 #include "content/public/browser/web_ui_controller.h" 13 #include "content/public/browser/web_ui_controller.h"
15 14
16 // The WebUI class for the uber page (chrome://chrome). It manages the UI for 15 // The WebUI class for the uber page (chrome://chrome). It manages the UI for
17 // the uber page (navigation bar and so forth) as well as WebUI objects for 16 // the uber page (navigation bar and so forth) as well as WebUI objects for
18 // pages that appear in the uber page. 17 // pages that appear in the uber page.
19 class UberUI : public WebUI, public content::WebUIController { 18 class UberUI : public content::WebUIController {
20 public: 19 public:
21 explicit UberUI(content::WebContents* contents); 20 explicit UberUI(WebUI* web_ui);
22 virtual ~UberUI(); 21 virtual ~UberUI();
23 22
24 // WebUIController implementation. 23 // WebUIController implementation.
25 virtual bool OverrideHandleWebUIMessage(const GURL& source_url, 24 virtual bool OverrideHandleWebUIMessage(const GURL& source_url,
26 const std::string& message, 25 const std::string& message,
27 const ListValue& args) OVERRIDE; 26 const ListValue& args) OVERRIDE;
28 27
29 // We forward these to |sub_uis_|. 28 // We forward these to |sub_uis_|.
30 virtual void RenderViewCreated(RenderViewHost* render_view_host) OVERRIDE; 29 virtual void RenderViewCreated(RenderViewHost* render_view_host) OVERRIDE;
31 virtual void RenderViewReused(RenderViewHost* render_view_host) OVERRIDE; 30 virtual void RenderViewReused(RenderViewHost* render_view_host) OVERRIDE;
32 virtual void DidBecomeActiveForReusedRenderView() OVERRIDE; 31 virtual void DidBecomeActiveForReusedRenderView() OVERRIDE;
33 32
34 private: 33 private:
35 // A map from URL origin to WebUI instance. 34 // A map from URL origin to WebUI instance.
36 typedef std::map<std::string, WebUI*> SubpageMap; 35 typedef std::map<std::string, WebUI*> SubpageMap;
37 36
38 // Creates and stores a WebUI for the given URL. 37 // Creates and stores a WebUI for the given URL.
39 void RegisterSubpage(const std::string& page_url); 38 void RegisterSubpage(const std::string& page_url);
40 39
41 // The WebUI*s in this map are owned. 40 // The WebUI*s in this map are owned.
42 SubpageMap sub_uis_; 41 SubpageMap sub_uis_;
43 42
44 DISALLOW_COPY_AND_ASSIGN(UberUI); 43 DISALLOW_COPY_AND_ASSIGN(UberUI);
45 }; 44 };
46 45
47 #endif // CHROME_BROWSER_UI_WEBUI_UBER_UBER_UI_H_ 46 #endif // CHROME_BROWSER_UI_WEBUI_UBER_UBER_UI_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698