Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Side by Side Diff: chrome/browser/ui/webui/task_manager_ui.cc

Issue 9224002: Make WebUI objects not derive from WebUI. WebUI objects own the controller. This is the ownership... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync to head to clear linux_chromeos browsertest failures Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/task_manager_ui.h" 5 #include "chrome/browser/ui/webui/task_manager_ui.h"
6 6
7 #include "base/values.h" 7 #include "base/values.h"
8 #include "chrome/browser/profiles/profile.h" 8 #include "chrome/browser/profiles/profile.h"
9 #include "chrome/browser/task_manager/task_manager.h" 9 #include "chrome/browser/task_manager/task_manager.h"
10 #include "chrome/browser/ui/webui/chrome_url_data_manager.h" 10 #include "chrome/browser/ui/webui/chrome_url_data_manager.h"
11 #include "chrome/browser/ui/webui/chrome_web_ui_data_source.h" 11 #include "chrome/browser/ui/webui/chrome_web_ui_data_source.h"
12 #include "chrome/browser/ui/webui/task_manager_handler.h" 12 #include "chrome/browser/ui/webui/task_manager_handler.h"
13 #include "chrome/common/url_constants.h" 13 #include "chrome/common/url_constants.h"
14 #include "content/browser/webui/web_ui.h"
14 #include "content/public/browser/web_contents.h" 15 #include "content/public/browser/web_contents.h"
15 #include "grit/browser_resources.h" 16 #include "grit/browser_resources.h"
16 #include "grit/generated_resources.h" 17 #include "grit/generated_resources.h"
17 #include "grit/chromium_strings.h" 18 #include "grit/chromium_strings.h"
18 #include "grit/theme_resources.h" 19 #include "grit/theme_resources.h"
19 #include "ui/base/l10n/l10n_util.h" 20 #include "ui/base/l10n/l10n_util.h"
20 #include "ui/base/resource/resource_bundle.h" 21 #include "ui/base/resource/resource_bundle.h"
21 22
22 using content::WebContents; 23 using content::WebContents;
23 24
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 } 71 }
71 72
72 } // namespace 73 } // namespace
73 74
74 /////////////////////////////////////////////////////////////////////////////// 75 ///////////////////////////////////////////////////////////////////////////////
75 // 76 //
76 // TaskManagerUI 77 // TaskManagerUI
77 // 78 //
78 /////////////////////////////////////////////////////////////////////////////// 79 ///////////////////////////////////////////////////////////////////////////////
79 80
80 TaskManagerUI::TaskManagerUI(WebContents* contents) : WebUI(contents, this) { 81 TaskManagerUI::TaskManagerUI(WebUI* web_ui) : WebUIController(web_ui) {
81 AddMessageHandler(new TaskManagerHandler(TaskManager::GetInstance())); 82 web_ui->AddMessageHandler(new TaskManagerHandler(TaskManager::GetInstance()));
82 83
83 // Set up the chrome://taskmanager/ source. 84 // Set up the chrome://taskmanager/ source.
84 ChromeWebUIDataSource* html_source = CreateTaskManagerUIHTMLSource(); 85 ChromeWebUIDataSource* html_source = CreateTaskManagerUIHTMLSource();
85 Profile* profile = Profile::FromBrowserContext(contents->GetBrowserContext()); 86 Profile* profile = Profile::FromBrowserContext(
87 web_ui->web_contents()->GetBrowserContext());
86 profile->GetChromeURLDataManager()->AddDataSource(html_source); 88 profile->GetChromeURLDataManager()->AddDataSource(html_source);
87 } 89 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698