Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: chrome/browser/ui/webui/quota_internals_ui.cc

Issue 9224002: Make WebUI objects not derive from WebUI. WebUI objects own the controller. This is the ownership... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync to head to clear linux_chromeos browsertest failures Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/quota_internals_ui.h" 5 #include "chrome/browser/ui/webui/quota_internals_ui.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/json/json_value_serializer.h" 9 #include "base/json/json_value_serializer.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
11 #include "chrome/browser/ui/webui/chrome_url_data_manager.h" 11 #include "chrome/browser/ui/webui/chrome_url_data_manager.h"
12 #include "chrome/browser/ui/webui/chrome_web_ui_data_source.h" 12 #include "chrome/browser/ui/webui/chrome_web_ui_data_source.h"
13 #include "chrome/browser/ui/webui/quota_internals_handler.h" 13 #include "chrome/browser/ui/webui/quota_internals_handler.h"
14 #include "chrome/common/url_constants.h" 14 #include "chrome/common/url_constants.h"
15 #include "content/browser/webui/web_ui.h"
15 #include "content/public/browser/web_contents.h" 16 #include "content/public/browser/web_contents.h"
16 #include "grit/quota_internals_resources.h" 17 #include "grit/quota_internals_resources.h"
17 #include "ui/base/l10n/l10n_util.h" 18 #include "ui/base/l10n/l10n_util.h"
18 #include "ui/base/resource/resource_bundle.h" 19 #include "ui/base/resource/resource_bundle.h"
19 20
20 using content::WebContents; 21 using content::WebContents;
21 22
22 namespace { 23 namespace {
23 24
24 ChromeWebUIDataSource* CreateQuotaInternalsHTMLSource() { 25 ChromeWebUIDataSource* CreateQuotaInternalsHTMLSource() {
25 ChromeWebUIDataSource* source = 26 ChromeWebUIDataSource* source =
26 new ChromeWebUIDataSource(chrome::kChromeUIQuotaInternalsHost); 27 new ChromeWebUIDataSource(chrome::kChromeUIQuotaInternalsHost);
27 28
28 source->set_json_path("strings.js"); 29 source->set_json_path("strings.js");
29 source->add_resource_path( 30 source->add_resource_path(
30 "event_handler.js", IDR_QUOTA_INTERNALS_EVENT_HANDLER_JS); 31 "event_handler.js", IDR_QUOTA_INTERNALS_EVENT_HANDLER_JS);
31 source->add_resource_path( 32 source->add_resource_path(
32 "message_dispatcher.js", IDR_QUOTA_INTERNALS_MESSAGE_DISPATCHER_JS); 33 "message_dispatcher.js", IDR_QUOTA_INTERNALS_MESSAGE_DISPATCHER_JS);
33 source->set_default_resource(IDR_QUOTA_INTERNALS_MAIN_HTML); 34 source->set_default_resource(IDR_QUOTA_INTERNALS_MAIN_HTML);
34 return source; 35 return source;
35 } 36 }
36 37
37 } // namespace 38 } // namespace
38 39
39 QuotaInternalsUI::QuotaInternalsUI(WebContents* contents) 40 QuotaInternalsUI::QuotaInternalsUI(WebUI* web_ui)
40 : WebUI(contents, this) { 41 : WebUIController(web_ui) {
41 AddMessageHandler(new quota_internals::QuotaInternalsHandler); 42 web_ui->AddMessageHandler(new quota_internals::QuotaInternalsHandler);
42 Profile* profile = Profile::FromBrowserContext(contents->GetBrowserContext()); 43 Profile* profile = Profile::FromBrowserContext(
44 web_ui->web_contents()->GetBrowserContext());
43 profile->GetChromeURLDataManager()->AddDataSource( 45 profile->GetChromeURLDataManager()->AddDataSource(
44 CreateQuotaInternalsHTMLSource()); 46 CreateQuotaInternalsHTMLSource());
45 } 47 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698