Make WebUI objects not derive from WebUI. WebUI objects own the controller. This is the ownership...

chrome/browser/ui/webui/print_preview/print_preview_ui.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/print_preview/print_preview_ui.h"
 
 #include <map>
 
 #include "base/lazy_instance.h"
 #include "base/metrics/histogram.h"
@@ skipping 54 matching lines @@
   PrintPreviewRequestIdMap map_;
   base::Lock lock_;
 };
 
 // Written to on the UI thread, read from any thread.
 base::LazyInstance<PrintPreviewRequestIdMapWithLock>
     g_print_preview_request_id_map = LAZY_INSTANCE_INITIALIZER;
 
 }  // namespace
 
-PrintPreviewUI::PrintPreviewUI(WebContents* contents)
-    : ConstrainedHtmlUI(contents),
+PrintPreviewUI::PrintPreviewUI(WebUI* web_ui)
+    : ConstrainedHtmlUI(web_ui),
       initial_preview_start_time_(base::TimeTicks::Now()),
       handler_(NULL),
       source_is_modifiable_(true),
       tab_closed_(false) {
   printing::PrintPreviewTabController* controller =
       printing::PrintPreviewTabController::GetInstance();
   is_dummy_ = (!controller || !controller->is_creating_print_preview_tab());
 
   // Set up the chrome://print/ data source.
-  Profile* profile = Profile::FromBrowserContext(contents->GetBrowserContext());
+  Profile* profile = Profile::FromBrowserContext(
+      web_ui->web_contents()->GetBrowserContext());
   profile->GetChromeURLDataManager()->AddDataSource(
       new PrintPreviewDataSource(is_dummy_));
   if (is_dummy_)
     return;
 
   // WebUI owns |handler_|.
   handler_ = new PrintPreviewHandler();
-  AddMessageHandler(handler_);
+  web_ui->AddMessageHandler(handler_);
 
   preview_ui_addr_str_ = GetPrintPreviewUIAddress();
   g_print_preview_request_id_map.Get().Set(preview_ui_addr_str_, -1);
 }
 
 PrintPreviewUI::~PrintPreviewUI() {
   if (is_dummy_)
     return;
 
   print_preview_data_service()->RemoveEntry(preview_ui_addr_str_);
@@ skipping 27 matching lines @@
   initiator_tab_title_ = job_title;
 }
 
 // static
 void PrintPreviewUI::SetSourceIsModifiable(
     TabContentsWrapper* print_preview_tab,
     bool source_is_modifiable) {
   if (!print_preview_tab || !print_preview_tab->web_contents()->GetWebUI())
     return;
   PrintPreviewUI* print_preview_ui = static_cast<PrintPreviewUI*>(
-      print_preview_tab->web_contents()->GetWebUI());
+      print_preview_tab->web_contents()->GetWebUI()->GetController());
   print_preview_ui->source_is_modifiable_ = source_is_modifiable;
 }
 
 // static
 void PrintPreviewUI::GetCurrentPrintPreviewStatus(
     const std::string& preview_ui_addr,
     int request_id,
     bool* cancel) {
   int current_id = -1;
   if (!g_print_preview_request_id_map.Get().Get(preview_ui_addr, &current_id)) {
     *cancel = true;
     return;
   }
   *cancel = (request_id != current_id);
 }
 
 std::string PrintPreviewUI::GetPrintPreviewUIAddress() const {
   // Store the PrintPreviewUIAddress as a string.
   // "0x" + deadc0de + '\0' = 2 + 2 * sizeof(this) + 1;
   char preview_ui_addr[2 + (2 * sizeof(this)) + 1];
   base::snprintf(preview_ui_addr, sizeof(preview_ui_addr), "%p", this);
   return preview_ui_addr;
 }
 
 void PrintPreviewUI::OnPrintPreviewTabClosed() {
   TabContentsWrapper* preview_tab =
-      TabContentsWrapper::GetCurrentWrapperForContents(web_contents());
+      TabContentsWrapper::GetCurrentWrapperForContents(
+        web_ui()->web_contents());
   printing::BackgroundPrintingManager* background_printing_manager =
       g_browser_process->background_printing_manager();
   if (background_printing_manager->HasPrintPreviewTab(preview_tab))
     return;
   OnClosePrintPreviewTab();
 }
 
 void PrintPreviewUI::OnInitiatorTabClosed() {
   TabContentsWrapper* preview_tab =
-      TabContentsWrapper::GetCurrentWrapperForContents(web_contents());
+      TabContentsWrapper::GetCurrentWrapperForContents(
+          web_ui()->web_contents());
   printing::BackgroundPrintingManager* background_printing_manager =
       g_browser_process->background_printing_manager();
   if (background_printing_manager->HasPrintPreviewTab(preview_tab))
-    CallJavascriptFunction("cancelPendingPrintRequest");
+    web_ui()->CallJavascriptFunction("cancelPendingPrintRequest");
   else
     OnClosePrintPreviewTab();
 }
 
 void PrintPreviewUI::OnPrintPreviewRequest(int request_id) {
   g_print_preview_request_id_map.Get().Set(preview_ui_addr_str_, request_id);
 }
 
 void PrintPreviewUI::OnShowSystemDialog() {
-  CallJavascriptFunction("onSystemDialogLinkClicked");
+  web_ui()->CallJavascriptFunction("onSystemDialogLinkClicked");
 }
 
 void PrintPreviewUI::OnDidGetPreviewPageCount(
     const PrintHostMsg_DidGetPreviewPageCount_Params& params) {
   DCHECK_GT(params.page_count, 0);
   base::FundamentalValue count(params.page_count);
   base::FundamentalValue request_id(params.preview_request_id);
-  CallJavascriptFunction("onDidGetPreviewPageCount", count, request_id);
+  web_ui()->CallJavascriptFunction("onDidGetPreviewPageCount", count, request_id);
 }
 
 void PrintPreviewUI::OnDidGetDefaultPageLayout(
     const PageSizeMargins& page_layout, bool has_custom_page_size_style) {
   if (page_layout.margin_top < 0 || page_layout.margin_left < 0 ||
       page_layout.margin_bottom < 0 || page_layout.margin_right < 0 ||
       page_layout.content_width < 0 || page_layout.content_height < 0) {
     NOTREACHED();
     return;
   }
 
   base::DictionaryValue layout;
   layout.SetDouble(printing::kSettingMarginTop, page_layout.margin_top);
   layout.SetDouble(printing::kSettingMarginLeft, page_layout.margin_left);
   layout.SetDouble(printing::kSettingMarginBottom, page_layout.margin_bottom);
   layout.SetDouble(printing::kSettingMarginRight, page_layout.margin_right);
   layout.SetDouble(printing::kSettingContentWidth, page_layout.content_width);
   layout.SetDouble(printing::kSettingContentHeight, page_layout.content_height);
 
   base::FundamentalValue has_page_size_style(has_custom_page_size_style);
-  CallJavascriptFunction("onDidGetDefaultPageLayout", layout,
-                         has_page_size_style);
+  web_ui()->CallJavascriptFunction("onDidGetDefaultPageLayout", layout,
+                                   has_page_size_style);
 }
 
 void PrintPreviewUI::OnDidPreviewPage(int page_number,
                                       int preview_request_id) {
   DCHECK_GE(page_number, 0);
   base::FundamentalValue number(page_number);
   StringValue ui_identifier(preview_ui_addr_str_);
   base::FundamentalValue request_id(preview_request_id);
-  CallJavascriptFunction("onDidPreviewPage", number, ui_identifier, request_id);
+  web_ui()->CallJavascriptFunction(
+      "onDidPreviewPage", number, ui_identifier, request_id);
 }
 
 void PrintPreviewUI::OnReusePreviewData(int preview_request_id) {
   base::StringValue ui_identifier(preview_ui_addr_str_);
   base::FundamentalValue ui_preview_request_id(preview_request_id);
-  CallJavascriptFunction("reloadPreviewPages", ui_identifier,
-                         ui_preview_request_id);
+  web_ui()->CallJavascriptFunction("reloadPreviewPages", ui_identifier,
+                                   ui_preview_request_id);
 }
 
 void PrintPreviewUI::OnPreviewDataIsAvailable(int expected_pages_count,
                                               int preview_request_id) {
   VLOG(1) << "Print preview request finished with "
           << expected_pages_count << " pages";
 
   if (!initial_preview_start_time_.is_null()) {
     UMA_HISTOGRAM_TIMES("PrintPreview.InitalDisplayTime",
                         base::TimeTicks::Now() - initial_preview_start_time_);
     UMA_HISTOGRAM_COUNTS("PrintPreview.PageCount.Initial",
                          expected_pages_count);
     initial_preview_start_time_ = base::TimeTicks();
   }
   base::StringValue ui_identifier(preview_ui_addr_str_);
   base::FundamentalValue ui_preview_request_id(preview_request_id);
-  CallJavascriptFunction("updatePrintPreview", ui_identifier,
-                         ui_preview_request_id);
+  web_ui()->CallJavascriptFunction("updatePrintPreview", ui_identifier,
+                                   ui_preview_request_id);
 }
 
 void PrintPreviewUI::OnTabDestroyed() {
   handler_->OnTabDestroyed();
 }
 
 void PrintPreviewUI::OnFileSelectionCancelled() {
-  CallJavascriptFunction("fileSelectionCancelled");
+  web_ui()->CallJavascriptFunction("fileSelectionCancelled");
 }
 
 void PrintPreviewUI::OnCancelPendingPreviewRequest() {
   g_print_preview_request_id_map.Get().Set(preview_ui_addr_str_, -1);
 }
 
 void PrintPreviewUI::OnPrintPreviewFailed() {
   handler_->OnPrintPreviewFailed();
-  CallJavascriptFunction("printPreviewFailed");
+  web_ui()->CallJavascriptFunction("printPreviewFailed");
 }
 
 void PrintPreviewUI::OnInvalidPrinterSettings() {
-  CallJavascriptFunction("invalidPrinterSettings");
+  web_ui()->CallJavascriptFunction("invalidPrinterSettings");
 }
 
 PrintPreviewDataService* PrintPreviewUI::print_preview_data_service() {
   return PrintPreviewDataService::GetInstance();
 }
 
 void PrintPreviewUI::OnHidePreviewTab() {
   TabContentsWrapper* preview_tab =
-      TabContentsWrapper::GetCurrentWrapperForContents(web_contents());
+      TabContentsWrapper::GetCurrentWrapperForContents(
+          web_ui()->web_contents());
   printing::BackgroundPrintingManager* background_printing_manager =
       g_browser_process->background_printing_manager();
   if (background_printing_manager->HasPrintPreviewTab(preview_tab))
     return;
 
   ConstrainedHtmlUIDelegate* delegate = GetConstrainedDelegate();
   if (!delegate)
     return;
   delegate->ReleaseTabContentsOnDialogClose();
   background_printing_manager->OwnPrintPreviewTab(preview_tab);
   OnClosePrintPreviewTab();
 }
 
 void PrintPreviewUI::OnClosePrintPreviewTab() {
   if (tab_closed_)
     return;
   tab_closed_ = true;
   ConstrainedHtmlUIDelegate* delegate = GetConstrainedDelegate();
   if (!delegate)
     return;
   delegate->GetHtmlDialogUIDelegate()->OnDialogClosed("");
   delegate->OnDialogCloseFromWebUI();
 }
 
 void PrintPreviewUI::OnReloadPrintersList() {
-  CallJavascriptFunction("reloadPrintersList");
+  web_ui()->CallJavascriptFunction("reloadPrintersList");
 }