Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: chrome/browser/ui/webui/print_preview/print_preview_handler_unittest.cc

Issue 9224002: Make WebUI objects not derive from WebUI. WebUI objects own the controller. This is the ownership... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync to head to clear linux_chromeos browsertest failures Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/json/json_writer.h" 5 #include "base/json/json_writer.h"
6 #include "base/values.h" 6 #include "base/values.h"
7 #include "chrome/browser/browser_process.h" 7 #include "chrome/browser/browser_process.h"
8 #include "chrome/browser/printing/background_printing_manager.h" 8 #include "chrome/browser/printing/background_printing_manager.h"
9 #include "chrome/browser/printing/print_preview_tab_controller.h" 9 #include "chrome/browser/printing/print_preview_tab_controller.h"
10 #include "chrome/browser/printing/print_preview_unit_test_base.h" 10 #include "chrome/browser/printing/print_preview_unit_test_base.h"
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 ASSERT_TRUE(initiator_tab); 60 ASSERT_TRUE(initiator_tab);
61 61
62 printing::PrintPreviewTabController* controller = 62 printing::PrintPreviewTabController* controller =
63 printing::PrintPreviewTabController::GetInstance(); 63 printing::PrintPreviewTabController::GetInstance();
64 ASSERT_TRUE(controller); 64 ASSERT_TRUE(controller);
65 65
66 initiator_tab->print_view_manager()->PrintPreviewNow(); 66 initiator_tab->print_view_manager()->PrintPreviewNow();
67 preview_tab_ = controller->GetOrCreatePreviewTab(initiator_tab); 67 preview_tab_ = controller->GetOrCreatePreviewTab(initiator_tab);
68 ASSERT_TRUE(preview_tab_); 68 ASSERT_TRUE(preview_tab_);
69 69
70 preview_ui_ = 70 preview_ui_ = static_cast<PrintPreviewUI*>(
71 static_cast<PrintPreviewUI*>(preview_tab_->web_contents()->GetWebUI()); 71 preview_tab_->web_contents()->GetWebUI()->GetController());
72 ASSERT_TRUE(preview_ui_); 72 ASSERT_TRUE(preview_ui_);
73 } 73 }
74 74
75 void DeletePrintPreviewTab() { 75 void DeletePrintPreviewTab() {
76 printing::BackgroundPrintingManager* bg_printing_manager = 76 printing::BackgroundPrintingManager* bg_printing_manager =
77 g_browser_process->background_printing_manager(); 77 g_browser_process->background_printing_manager();
78 ASSERT_TRUE(bg_printing_manager->HasPrintPreviewTab(preview_tab_)); 78 ASSERT_TRUE(bg_printing_manager->HasPrintPreviewTab(preview_tab_));
79 79
80 // Deleting TabContentsWrapper* to avoid warings from pref_notifier_impl.cc 80 // Deleting TabContentsWrapper* to avoid warings from pref_notifier_impl.cc
81 // after the test ends. 81 // after the test ends.
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
252 double margin_value; 252 double margin_value;
253 EXPECT_FALSE(initial_settings.GetDouble(printing::kSettingMarginTop, 253 EXPECT_FALSE(initial_settings.GetDouble(printing::kSettingMarginTop,
254 &margin_value)); 254 &margin_value));
255 EXPECT_FALSE(initial_settings.GetDouble(printing::kSettingMarginRight, 255 EXPECT_FALSE(initial_settings.GetDouble(printing::kSettingMarginRight,
256 &margin_value)); 256 &margin_value));
257 EXPECT_FALSE(initial_settings.GetDouble(printing::kSettingMarginBottom, 257 EXPECT_FALSE(initial_settings.GetDouble(printing::kSettingMarginBottom,
258 &margin_value)); 258 &margin_value));
259 EXPECT_FALSE(initial_settings.GetDouble(printing::kSettingMarginLeft, 259 EXPECT_FALSE(initial_settings.GetDouble(printing::kSettingMarginLeft,
260 &margin_value)); 260 &margin_value));
261 } 261 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698