Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: chrome/browser/ui/webui/options/language_options_handler_common.cc

Issue 9224002: Make WebUI objects not derive from WebUI. WebUI objects own the controller. This is the ownership... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync to head to clear linux_chromeos browsertest failures Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/options/language_options_handler_common.h" 5 #include "chrome/browser/ui/webui/options/language_options_handler_common.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
11 11
12 #include "base/basictypes.h" 12 #include "base/basictypes.h"
13 #include "base/bind.h" 13 #include "base/bind.h"
14 #include "base/command_line.h" 14 #include "base/command_line.h"
15 #include "base/stringprintf.h" 15 #include "base/stringprintf.h"
16 #include "base/utf_string_conversions.h" 16 #include "base/utf_string_conversions.h"
17 #include "base/values.h" 17 #include "base/values.h"
18 #include "chrome/browser/browser_process.h" 18 #include "chrome/browser/browser_process.h"
19 #include "chrome/browser/prefs/pref_service.h" 19 #include "chrome/browser/prefs/pref_service.h"
20 #include "chrome/browser/ui/browser_list.h" 20 #include "chrome/browser/ui/browser_list.h"
21 #include "chrome/common/chrome_switches.h" 21 #include "chrome/common/chrome_switches.h"
22 #include "chrome/common/pref_names.h" 22 #include "chrome/common/pref_names.h"
23 #include "chrome/common/spellcheck_common.h" 23 #include "chrome/common/spellcheck_common.h"
24 #include "content/browser/webui/web_ui.h"
24 #include "content/public/browser/user_metrics.h" 25 #include "content/public/browser/user_metrics.h"
25 #include "grit/chromium_strings.h" 26 #include "grit/chromium_strings.h"
26 #include "grit/generated_resources.h" 27 #include "grit/generated_resources.h"
27 #include "ui/base/l10n/l10n_util.h" 28 #include "ui/base/l10n/l10n_util.h"
28 29
29 using content::UserMetricsAction; 30 using content::UserMetricsAction;
30 31
31 LanguageOptionsHandlerCommon::LanguageOptionsHandlerCommon() { 32 LanguageOptionsHandlerCommon::LanguageOptionsHandlerCommon() {
32 } 33 }
33 34
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 } 159 }
159 160
160 void LanguageOptionsHandlerCommon::SpellCheckLanguageChangeCallback( 161 void LanguageOptionsHandlerCommon::SpellCheckLanguageChangeCallback(
161 const ListValue* args) { 162 const ListValue* args) {
162 const std::string language_code = UTF16ToASCII(ExtractStringValue(args)); 163 const std::string language_code = UTF16ToASCII(ExtractStringValue(args));
163 CHECK(!language_code.empty()); 164 CHECK(!language_code.empty());
164 const std::string action = base::StringPrintf( 165 const std::string action = base::StringPrintf(
165 "LanguageOptions_SpellCheckLanguageChange_%s", language_code.c_str()); 166 "LanguageOptions_SpellCheckLanguageChange_%s", language_code.c_str());
166 content::RecordComputedAction(action); 167 content::RecordComputedAction(action);
167 } 168 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698