Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Side by Side Diff: chrome/browser/ui/webui/net_internals/net_internals_ui.h

Issue 9224002: Make WebUI objects not derive from WebUI. WebUI objects own the controller. This is the ownership... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync to head to clear linux_chromeos browsertest failures Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_NET_INTERNALS_NET_INTERNALS_UI_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_NET_INTERNALS_NET_INTERNALS_UI_H_
6 #define CHROME_BROWSER_UI_WEBUI_NET_INTERNALS_NET_INTERNALS_UI_H_ 6 #define CHROME_BROWSER_UI_WEBUI_NET_INTERNALS_NET_INTERNALS_UI_H_
7 #pragma once 7 #pragma once
8
9 #include "content/browser/webui/web_ui.h"
10 #include "content/public/browser/web_ui_controller.h" 8 #include "content/public/browser/web_ui_controller.h"
11 9
12 namespace base { 10 namespace base {
13 class Value; 11 class Value;
14 } 12 }
15 13
16 class NetInternalsUI : public WebUI, public content::WebUIController { 14 class NetInternalsUI : public content::WebUIController {
17 public: 15 public:
18 explicit NetInternalsUI(content::WebContents* contents); 16 explicit NetInternalsUI(WebUI* web_ui);
19 17
20 // Returns a Value containing constants NetInternals needs to load a log file. 18 // Returns a Value containing constants NetInternals needs to load a log file.
21 // Safe to call on any thread. Caller takes ownership of the returned Value. 19 // Safe to call on any thread. Caller takes ownership of the returned Value.
22 static base::Value* GetConstants(); 20 static base::Value* GetConstants();
23 21
24 private: 22 private:
25 DISALLOW_COPY_AND_ASSIGN(NetInternalsUI); 23 DISALLOW_COPY_AND_ASSIGN(NetInternalsUI);
26 }; 24 };
27 25
28 #endif // CHROME_BROWSER_UI_WEBUI_NET_INTERNALS_NET_INTERNALS_UI_H_ 26 #endif // CHROME_BROWSER_UI_WEBUI_NET_INTERNALS_NET_INTERNALS_UI_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698