Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Side by Side Diff: chrome/browser/ui/webui/net_internals/net_internals_ui.cc

Issue 9224002: Make WebUI objects not derive from WebUI. WebUI objects own the controller. This is the ownership... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync to head to clear linux_chromeos browsertest failures Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/net_internals/net_internals_ui.h" 5 #include "chrome/browser/ui/webui/net_internals/net_internals_ui.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <list> 8 #include <list>
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
(...skipping 24 matching lines...) Expand all
35 #include "chrome/browser/prerender/prerender_manager.h" 35 #include "chrome/browser/prerender/prerender_manager.h"
36 #include "chrome/browser/prerender/prerender_manager_factory.h" 36 #include "chrome/browser/prerender/prerender_manager_factory.h"
37 #include "chrome/browser/profiles/profile.h" 37 #include "chrome/browser/profiles/profile.h"
38 #include "chrome/browser/ui/webui/chrome_url_data_manager.h" 38 #include "chrome/browser/ui/webui/chrome_url_data_manager.h"
39 #include "chrome/browser/ui/webui/chrome_web_ui_data_source.h" 39 #include "chrome/browser/ui/webui/chrome_web_ui_data_source.h"
40 #include "chrome/common/chrome_notification_types.h" 40 #include "chrome/common/chrome_notification_types.h"
41 #include "chrome/common/chrome_paths.h" 41 #include "chrome/common/chrome_paths.h"
42 #include "chrome/common/chrome_version_info.h" 42 #include "chrome/common/chrome_version_info.h"
43 #include "chrome/common/pref_names.h" 43 #include "chrome/common/pref_names.h"
44 #include "chrome/common/url_constants.h" 44 #include "chrome/common/url_constants.h"
45 #include "content/browser/webui/web_ui.h"
45 #include "content/public/browser/browser_thread.h" 46 #include "content/public/browser/browser_thread.h"
46 #include "content/public/browser/notification_details.h" 47 #include "content/public/browser/notification_details.h"
47 #include "content/public/browser/web_contents.h" 48 #include "content/public/browser/web_contents.h"
48 #include "content/public/browser/web_ui_message_handler.h" 49 #include "content/public/browser/web_ui_message_handler.h"
49 #include "grit/generated_resources.h" 50 #include "grit/generated_resources.h"
50 #include "grit/net_internals_resources.h" 51 #include "grit/net_internals_resources.h"
51 #include "net/base/escape.h" 52 #include "net/base/escape.h"
52 #include "net/base/host_cache.h" 53 #include "net/base/host_cache.h"
53 #include "net/base/host_resolver.h" 54 #include "net/base/host_resolver.h"
54 #include "net/base/net_errors.h" 55 #include "net/base/net_errors.h"
(...skipping 1575 matching lines...) Expand 10 before | Expand all | Expand 10 after
1630 const int64 kUnixEpochMs = 11644473600000LL; 1631 const int64 kUnixEpochMs = 11644473600000LL;
1631 int64 tick_to_unix_time_ms = tick_to_time_ms - kUnixEpochMs; 1632 int64 tick_to_unix_time_ms = tick_to_time_ms - kUnixEpochMs;
1632 1633
1633 // Pass it as a string, since it may be too large to fit in an integer. 1634 // Pass it as a string, since it may be too large to fit in an integer.
1634 constants_dict->SetString("timeTickOffset", 1635 constants_dict->SetString("timeTickOffset",
1635 base::Int64ToString(tick_to_unix_time_ms)); 1636 base::Int64ToString(tick_to_unix_time_ms));
1636 } 1637 }
1637 return constants_dict; 1638 return constants_dict;
1638 } 1639 }
1639 1640
1640 NetInternalsUI::NetInternalsUI(WebContents* contents) : WebUI(contents, this) { 1641 NetInternalsUI::NetInternalsUI(WebUI* web_ui) : WebUIController(web_ui) {
1641 AddMessageHandler(new NetInternalsMessageHandler()); 1642 web_ui->AddMessageHandler(new NetInternalsMessageHandler());
1642 1643
1643 // Set up the chrome://net-internals/ source. 1644 // Set up the chrome://net-internals/ source.
1644 Profile* profile = Profile::FromBrowserContext(contents->GetBrowserContext()); 1645 Profile* profile = Profile::FromBrowserContext(
1646 web_ui->web_contents()->GetBrowserContext());
1645 profile->GetChromeURLDataManager()->AddDataSource( 1647 profile->GetChromeURLDataManager()->AddDataSource(
1646 CreateNetInternalsHTMLSource()); 1648 CreateNetInternalsHTMLSource());
1647 } 1649 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698