Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: chrome/browser/ui/webui/history_ui.h

Issue 9224002: Make WebUI objects not derive from WebUI. WebUI objects own the controller. This is the ownership... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync to head to clear linux_chromeos browsertest failures Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_HISTORY_UI_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_HISTORY_UI_H_
6 #define CHROME_BROWSER_UI_WEBUI_HISTORY_UI_H_ 6 #define CHROME_BROWSER_UI_WEBUI_HISTORY_UI_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
11 #include "base/string16.h" 11 #include "base/string16.h"
12 #include "chrome/browser/cancelable_request.h" 12 #include "chrome/browser/cancelable_request.h"
13 #include "chrome/browser/history/history.h" 13 #include "chrome/browser/history/history.h"
14 #include "chrome/browser/ui/webui/chrome_url_data_manager.h" 14 #include "chrome/browser/ui/webui/chrome_url_data_manager.h"
15 #include "content/browser/webui/web_ui.h"
16 #include "content/public/browser/notification_registrar.h" 15 #include "content/public/browser/notification_registrar.h"
17 #include "content/public/browser/web_ui_controller.h" 16 #include "content/public/browser/web_ui_controller.h"
18 #include "content/public/browser/web_ui_message_handler.h" 17 #include "content/public/browser/web_ui_message_handler.h"
19 18
20 // The handler for Javascript messages related to the "history" view. 19 // The handler for Javascript messages related to the "history" view.
21 class BrowsingHistoryHandler : public content::WebUIMessageHandler, 20 class BrowsingHistoryHandler : public content::WebUIMessageHandler,
22 public content::NotificationObserver { 21 public content::NotificationObserver {
23 public: 22 public:
24 BrowsingHistoryHandler(); 23 BrowsingHistoryHandler();
25 virtual ~BrowsingHistoryHandler(); 24 virtual ~BrowsingHistoryHandler();
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 69
71 // Our consumer for delete requests to the history service. 70 // Our consumer for delete requests to the history service.
72 CancelableRequestConsumerT<int, 0> cancelable_delete_consumer_; 71 CancelableRequestConsumerT<int, 0> cancelable_delete_consumer_;
73 72
74 // The list of URLs that are in the process of being deleted. 73 // The list of URLs that are in the process of being deleted.
75 std::set<GURL> urls_to_be_deleted_; 74 std::set<GURL> urls_to_be_deleted_;
76 75
77 DISALLOW_COPY_AND_ASSIGN(BrowsingHistoryHandler); 76 DISALLOW_COPY_AND_ASSIGN(BrowsingHistoryHandler);
78 }; 77 };
79 78
80 class HistoryUI : public WebUI, public content::WebUIController { 79 class HistoryUI : public content::WebUIController {
81 public: 80 public:
82 explicit HistoryUI(content::WebContents* contents); 81 explicit HistoryUI(WebUI* web_ui);
83 82
84 // Return the URL for a given search term. 83 // Return the URL for a given search term.
85 static const GURL GetHistoryURLWithSearchText(const string16& text); 84 static const GURL GetHistoryURLWithSearchText(const string16& text);
86 85
87 static RefCountedMemory* GetFaviconResourceBytes(); 86 static RefCountedMemory* GetFaviconResourceBytes();
88 87
89 private: 88 private:
90 DISALLOW_COPY_AND_ASSIGN(HistoryUI); 89 DISALLOW_COPY_AND_ASSIGN(HistoryUI);
91 }; 90 };
92 91
93 #endif // CHROME_BROWSER_UI_WEBUI_HISTORY_UI_H_ 92 #endif // CHROME_BROWSER_UI_WEBUI_HISTORY_UI_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698