Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Side by Side Diff: chrome/browser/ui/webui/extensions/extensions_ui.cc

Issue 9224002: Make WebUI objects not derive from WebUI. WebUI objects own the controller. This is the ownership... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync to head to clear linux_chromeos browsertest failures Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/extensions/extensions_ui.h" 5 #include "chrome/browser/ui/webui/extensions/extensions_ui.h"
6 6
7 #include "chrome/browser/profiles/profile.h" 7 #include "chrome/browser/profiles/profile.h"
8 #include "chrome/browser/ui/webui/chrome_url_data_manager.h" 8 #include "chrome/browser/ui/webui/chrome_url_data_manager.h"
9 #include "chrome/browser/ui/webui/chrome_web_ui_data_source.h" 9 #include "chrome/browser/ui/webui/chrome_web_ui_data_source.h"
10 #include "chrome/browser/ui/webui/options/extension_settings_handler.h" 10 #include "chrome/browser/ui/webui/options/extension_settings_handler.h"
11 #include "chrome/browser/ui/webui/shared_resources_data_source.h" 11 #include "chrome/browser/ui/webui/shared_resources_data_source.h"
12 #include "chrome/common/url_constants.h" 12 #include "chrome/common/url_constants.h"
13 #include "content/browser/webui/web_ui.h"
13 #include "content/public/browser/web_contents.h" 14 #include "content/public/browser/web_contents.h"
14 #include "grit/browser_resources.h" 15 #include "grit/browser_resources.h"
15 16
16 using content::WebContents; 17 using content::WebContents;
17 18
18 namespace { 19 namespace {
19 20
20 ChromeWebUIDataSource* CreateExtensionsHTMLSource() { 21 ChromeWebUIDataSource* CreateExtensionsHTMLSource() {
21 ChromeWebUIDataSource* source = 22 ChromeWebUIDataSource* source =
22 new ChromeWebUIDataSource(chrome::kChromeUIExtensionsFrameHost); 23 new ChromeWebUIDataSource(chrome::kChromeUIExtensionsFrameHost);
23 24
24 source->set_json_path("strings.js"); 25 source->set_json_path("strings.js");
25 source->add_resource_path("extensions.js", IDR_EXTENSIONS_JS); 26 source->add_resource_path("extensions.js", IDR_EXTENSIONS_JS);
26 source->add_resource_path("extension_list.js", IDR_EXTENSION_LIST_JS); 27 source->add_resource_path("extension_list.js", IDR_EXTENSION_LIST_JS);
27 source->set_default_resource(IDR_EXTENSIONS_HTML); 28 source->set_default_resource(IDR_EXTENSIONS_HTML);
28 return source; 29 return source;
29 } 30 }
30 31
31 } // namespace 32 } // namespace
32 33
33 ExtensionsUI::ExtensionsUI(WebContents* contents) : WebUI(contents, this) { 34 ExtensionsUI::ExtensionsUI(WebUI* web_ui) : WebUIController(web_ui) {
34 Profile* profile = Profile::FromBrowserContext(contents->GetBrowserContext()); 35 Profile* profile = Profile::FromBrowserContext(
36 web_ui->web_contents()->GetBrowserContext());
35 ChromeWebUIDataSource* source = CreateExtensionsHTMLSource(); 37 ChromeWebUIDataSource* source = CreateExtensionsHTMLSource();
36 profile->GetChromeURLDataManager()->AddDataSource(source); 38 profile->GetChromeURLDataManager()->AddDataSource(source);
37 profile->GetChromeURLDataManager()->AddDataSource( 39 profile->GetChromeURLDataManager()->AddDataSource(
38 new SharedResourcesDataSource()); 40 new SharedResourcesDataSource());
39 41
40 ExtensionSettingsHandler* handler = new ExtensionSettingsHandler(); 42 ExtensionSettingsHandler* handler = new ExtensionSettingsHandler();
41 handler->GetLocalizedValues(source->localized_strings()); 43 handler->GetLocalizedValues(source->localized_strings());
42 AddMessageHandler(handler); 44 web_ui->AddMessageHandler(handler);
43 } 45 }
44 46
45 ExtensionsUI::~ExtensionsUI() { 47 ExtensionsUI::~ExtensionsUI() {
46 } 48 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698