Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: chrome/browser/ui/webui/devtools_ui.cc

Issue 9224002: Make WebUI objects not derive from WebUI. WebUI objects own the controller. This is the ownership... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync to head to clear linux_chromeos browsertest failures Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/devtools_ui.h" 5 #include "chrome/browser/ui/webui/devtools_ui.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/string_util.h" 10 #include "base/string_util.h"
11 #include "chrome/browser/net/chrome_url_request_context.h" 11 #include "chrome/browser/net/chrome_url_request_context.h"
12 #include "chrome/browser/profiles/profile.h" 12 #include "chrome/browser/profiles/profile.h"
13 #include "chrome/browser/ui/webui/chrome_url_data_manager.h" 13 #include "chrome/browser/ui/webui/chrome_url_data_manager.h"
14 #include "chrome/common/url_constants.h" 14 #include "chrome/common/url_constants.h"
15 #include "content/browser/renderer_host/render_view_host.h" 15 #include "content/browser/renderer_host/render_view_host.h"
16 #include "content/browser/webui/web_ui.h"
16 #include "content/public/browser/browser_thread.h" 17 #include "content/public/browser/browser_thread.h"
17 #include "content/public/browser/devtools_client_host.h" 18 #include "content/public/browser/devtools_client_host.h"
18 #include "content/public/browser/web_contents.h" 19 #include "content/public/browser/web_contents.h"
19 #include "grit/devtools_resources_map.h" 20 #include "grit/devtools_resources_map.h"
20 #include "ui/base/resource/resource_bundle.h" 21 #include "ui/base/resource/resource_bundle.h"
21 22
22 using content::BrowserThread; 23 using content::BrowserThread;
23 using content::WebContents; 24 using content::WebContents;
24 25
25 namespace { 26 namespace {
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 void DevToolsUI::RegisterDevToolsDataSource(Profile* profile) { 94 void DevToolsUI::RegisterDevToolsDataSource(Profile* profile) {
94 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 95 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
95 static bool registered = false; 96 static bool registered = false;
96 if (!registered) { 97 if (!registered) {
97 DevToolsDataSource* data_source = new DevToolsDataSource(); 98 DevToolsDataSource* data_source = new DevToolsDataSource();
98 profile->GetChromeURLDataManager()->AddDataSource(data_source); 99 profile->GetChromeURLDataManager()->AddDataSource(data_source);
99 registered = true; 100 registered = true;
100 } 101 }
101 } 102 }
102 103
103 DevToolsUI::DevToolsUI(WebContents* contents) : WebUI(contents, this) { 104 DevToolsUI::DevToolsUI(WebUI* web_ui) : WebUIController(web_ui) {
104 DevToolsDataSource* data_source = new DevToolsDataSource(); 105 DevToolsDataSource* data_source = new DevToolsDataSource();
105 Profile* profile = Profile::FromBrowserContext(contents->GetBrowserContext()); 106 Profile* profile = Profile::FromBrowserContext(
107 web_ui->web_contents()->GetBrowserContext());
106 profile->GetChromeURLDataManager()->AddDataSource(data_source); 108 profile->GetChromeURLDataManager()->AddDataSource(data_source);
107 } 109 }
108 110
109 void DevToolsUI::RenderViewCreated(RenderViewHost* render_view_host) { 111 void DevToolsUI::RenderViewCreated(RenderViewHost* render_view_host) {
110 content::DevToolsClientHost::SetupDevToolsFrontendClient(render_view_host); 112 content::DevToolsClientHost::SetupDevToolsFrontendClient(render_view_host);
111 } 113 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698