Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Side by Side Diff: chrome/browser/ui/webui/chromeos/register_page_ui.cc

Issue 9224002: Make WebUI objects not derive from WebUI. WebUI objects own the controller. This is the ownership... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync to head to clear linux_chromeos browsertest failures Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/chromeos/register_page_ui.h" 5 #include "chrome/browser/ui/webui/chromeos/register_page_ui.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
11 #include "base/logging.h" 11 #include "base/logging.h"
12 #include "base/memory/weak_ptr.h" 12 #include "base/memory/weak_ptr.h"
13 #include "base/string_piece.h" 13 #include "base/string_piece.h"
14 #include "base/utf_string_conversions.h" 14 #include "base/utf_string_conversions.h"
15 #include "base/values.h" 15 #include "base/values.h"
16 #include "chrome/browser/browser_process.h" 16 #include "chrome/browser/browser_process.h"
17 #include "chrome/browser/chromeos/cros/cros_library.h" 17 #include "chrome/browser/chromeos/cros/cros_library.h"
18 #include "chrome/browser/chromeos/cros/network_library.h" 18 #include "chrome/browser/chromeos/cros/network_library.h"
19 #include "chrome/browser/chromeos/customization_document.h" 19 #include "chrome/browser/chromeos/customization_document.h"
20 #include "chrome/browser/chromeos/login/wizard_controller.h" 20 #include "chrome/browser/chromeos/login/wizard_controller.h"
21 #include "chrome/browser/chromeos/system/runtime_environment.h" 21 #include "chrome/browser/chromeos/system/runtime_environment.h"
22 #include "chrome/browser/chromeos/system/statistics_provider.h" 22 #include "chrome/browser/chromeos/system/statistics_provider.h"
23 #include "chrome/browser/chromeos/version_loader.h" 23 #include "chrome/browser/chromeos/version_loader.h"
24 #include "chrome/browser/profiles/profile.h" 24 #include "chrome/browser/profiles/profile.h"
25 #include "chrome/browser/ui/webui/chrome_url_data_manager.h" 25 #include "chrome/browser/ui/webui/chrome_url_data_manager.h"
26 #include "chrome/common/url_constants.h" 26 #include "chrome/common/url_constants.h"
27 #include "content/browser/webui/web_ui.h"
27 #include "content/public/browser/browser_thread.h" 28 #include "content/public/browser/browser_thread.h"
28 #include "content/public/browser/web_contents.h" 29 #include "content/public/browser/web_contents.h"
29 #include "content/public/browser/web_ui_message_handler.h" 30 #include "content/public/browser/web_ui_message_handler.h"
30 #include "googleurl/src/gurl.h" 31 #include "googleurl/src/gurl.h"
31 #include "grit/browser_resources.h" 32 #include "grit/browser_resources.h"
32 #include "ui/base/resource/resource_bundle.h" 33 #include "ui/base/resource/resource_bundle.h"
33 34
34 using content::WebContents; 35 using content::WebContents;
35 using content::WebUIMessageHandler; 36 using content::WebUIMessageHandler;
36 37
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
287 web_ui()->CallJavascriptFunction(kJsApiSetUserInfo, value); 288 web_ui()->CallJavascriptFunction(kJsApiSetUserInfo, value);
288 #endif 289 #endif
289 } 290 }
290 291
291 //////////////////////////////////////////////////////////////////////////////// 292 ////////////////////////////////////////////////////////////////////////////////
292 // 293 //
293 // RegisterPageUI 294 // RegisterPageUI
294 // 295 //
295 //////////////////////////////////////////////////////////////////////////////// 296 ////////////////////////////////////////////////////////////////////////////////
296 297
297 RegisterPageUI::RegisterPageUI(WebContents* contents) : WebUI(contents, this) { 298 RegisterPageUI::RegisterPageUI(WebUI* web_ui) : WebUIController(web_ui) {
298 RegisterPageHandler* handler = new RegisterPageHandler(); 299 RegisterPageHandler* handler = new RegisterPageHandler();
299 AddMessageHandler(handler); 300 web_ui->AddMessageHandler(handler);
300 RegisterPageUIHTMLSource* html_source = new RegisterPageUIHTMLSource(); 301 RegisterPageUIHTMLSource* html_source = new RegisterPageUIHTMLSource();
301 302
302 // Set up the chrome://register/ source. 303 // Set up the chrome://register/ source.
303 Profile* profile = Profile::FromBrowserContext(contents->GetBrowserContext()); 304 Profile* profile = Profile::FromBrowserContext(
305 web_ui->web_contents()->GetBrowserContext());
304 profile->GetChromeURLDataManager()->AddDataSource(html_source); 306 profile->GetChromeURLDataManager()->AddDataSource(html_source);
305 } 307 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698