Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: chrome/browser/ui/webui/chromeos/mobile_setup_ui.h

Issue 9224002: Make WebUI objects not derive from WebUI. WebUI objects own the controller. This is the ownership... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync to head to clear linux_chromeos browsertest failures Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_CHROMEOS_MOBILE_SETUP_UI_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_CHROMEOS_MOBILE_SETUP_UI_H_
6 #define CHROME_BROWSER_UI_WEBUI_CHROMEOS_MOBILE_SETUP_UI_H_ 6 #define CHROME_BROWSER_UI_WEBUI_CHROMEOS_MOBILE_SETUP_UI_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/memory/weak_ptr.h" 9 #include "base/memory/weak_ptr.h"
10 #include "content/browser/webui/web_ui.h"
11 #include "content/public/browser/web_ui_controller.h" 10 #include "content/public/browser/web_ui_controller.h"
12 11
13 class PortalFrameLoadObserver; 12 class PortalFrameLoadObserver;
14 // A custom WebUI that defines datasource for mobile setup registration page 13 // A custom WebUI that defines datasource for mobile setup registration page
15 // that is used in Chrome OS activate modem and perform plan subscription tasks. 14 // that is used in Chrome OS activate modem and perform plan subscription tasks.
16 class MobileSetupUI : public WebUI, 15 class MobileSetupUI : public content::WebUIController,
17 public content::WebUIController,
18 public base::SupportsWeakPtr<MobileSetupUI> { 16 public base::SupportsWeakPtr<MobileSetupUI> {
19 public: 17 public:
20 explicit MobileSetupUI(content::WebContents* contents); 18 explicit MobileSetupUI(WebUI* web_ui);
21 19
22 void OnObserverDeleted(); 20 void OnObserverDeleted();
23 21
24 private: 22 private:
25 // WebUIController overrides. 23 // WebUIController overrides.
26 virtual void RenderViewCreated(RenderViewHost* render_view_host) OVERRIDE; 24 virtual void RenderViewCreated(RenderViewHost* render_view_host) OVERRIDE;
27 25
28 PortalFrameLoadObserver* frame_load_observer_; 26 PortalFrameLoadObserver* frame_load_observer_;
29 DISALLOW_COPY_AND_ASSIGN(MobileSetupUI); 27 DISALLOW_COPY_AND_ASSIGN(MobileSetupUI);
30 }; 28 };
31 29
32 #endif // CHROME_BROWSER_UI_WEBUI_CHROMEOS_MOBILE_SETUP_UI_H_ 30 #endif // CHROME_BROWSER_UI_WEBUI_CHROMEOS_MOBILE_SETUP_UI_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698