Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Side by Side Diff: chrome/browser/ui/webui/chromeos/choose_mobile_network_ui.cc

Issue 9224002: Make WebUI objects not derive from WebUI. WebUI objects own the controller. This is the ownership... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync to head to clear linux_chromeos browsertest failures Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/chromeos/choose_mobile_network_ui.h" 5 #include "chrome/browser/ui/webui/chromeos/choose_mobile_network_ui.h"
6 6
7 #include <set> 7 #include <set>
8 #include <string> 8 #include <string>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
11 #include "base/bind_helpers.h" 11 #include "base/bind_helpers.h"
12 #include "base/logging.h" 12 #include "base/logging.h"
13 #include "base/string_number_conversions.h" 13 #include "base/string_number_conversions.h"
14 #include "base/string_piece.h" 14 #include "base/string_piece.h"
15 #include "base/values.h" 15 #include "base/values.h"
16 #include "chrome/browser/chromeos/cros/cros_library.h" 16 #include "chrome/browser/chromeos/cros/cros_library.h"
17 #include "chrome/browser/chromeos/cros/network_library.h" 17 #include "chrome/browser/chromeos/cros/network_library.h"
18 #include "chrome/browser/profiles/profile.h" 18 #include "chrome/browser/profiles/profile.h"
19 #include "chrome/browser/ui/webui/chrome_url_data_manager.h" 19 #include "chrome/browser/ui/webui/chrome_url_data_manager.h"
20 #include "chrome/browser/ui/webui/chrome_web_ui_data_source.h" 20 #include "chrome/browser/ui/webui/chrome_web_ui_data_source.h"
21 #include "chrome/common/jstemplate_builder.h" 21 #include "chrome/common/jstemplate_builder.h"
22 #include "chrome/common/url_constants.h" 22 #include "chrome/common/url_constants.h"
23 #include "content/browser/webui/web_ui.h"
23 #include "content/public/browser/browser_thread.h" 24 #include "content/public/browser/browser_thread.h"
24 #include "content/public/browser/web_contents.h" 25 #include "content/public/browser/web_contents.h"
25 #include "content/public/browser/web_ui_message_handler.h" 26 #include "content/public/browser/web_ui_message_handler.h"
26 #include "grit/browser_resources.h" 27 #include "grit/browser_resources.h"
27 #include "grit/generated_resources.h" 28 #include "grit/generated_resources.h"
28 #include "ui/base/l10n/l10n_util.h" 29 #include "ui/base/l10n/l10n_util.h"
29 #include "ui/base/resource/resource_bundle.h" 30 #include "ui/base/resource/resource_bundle.h"
30 31
31 using content::WebContents; 32 using content::WebContents;
32 using content::WebUIMessageHandler; 33 using content::WebUIMessageHandler;
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 if (has_pending_results_) { 204 if (has_pending_results_) {
204 web_ui()->CallJavascriptFunction(kJsApiShowNetworks, networks_list_); 205 web_ui()->CallJavascriptFunction(kJsApiShowNetworks, networks_list_);
205 networks_list_.Clear(); 206 networks_list_.Clear();
206 has_pending_results_ = false; 207 has_pending_results_ = false;
207 } 208 }
208 is_page_ready_ = true; 209 is_page_ready_ = true;
209 } 210 }
210 211
211 } // namespace 212 } // namespace
212 213
213 ChooseMobileNetworkUI::ChooseMobileNetworkUI(WebContents* contents) 214 ChooseMobileNetworkUI::ChooseMobileNetworkUI(WebUI* web_ui)
214 : WebUI(contents, this) { 215 : WebUIController(web_ui) {
215 ChooseMobileNetworkHandler* handler = new ChooseMobileNetworkHandler(); 216 ChooseMobileNetworkHandler* handler = new ChooseMobileNetworkHandler();
216 AddMessageHandler(handler); 217 web_ui->AddMessageHandler(handler);
217 // Set up the "chrome://choose-mobile-network" source. 218 // Set up the "chrome://choose-mobile-network" source.
218 Profile* profile = Profile::FromBrowserContext(contents->GetBrowserContext()); 219 Profile* profile = Profile::FromBrowserContext(
220 web_ui->web_contents()->GetBrowserContext());
219 profile->GetChromeURLDataManager()->AddDataSource( 221 profile->GetChromeURLDataManager()->AddDataSource(
220 CreateChooseMobileNetworkUIHTMLSource()); 222 CreateChooseMobileNetworkUIHTMLSource());
221 } 223 }
222 224
223 } // namespace chromeos 225 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698