Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: chrome/browser/ui/webui/chrome_web_ui_factory.h

Issue 9224002: Make WebUI objects not derive from WebUI. WebUI objects own the controller. This is the ownership... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync to head to clear linux_chromeos browsertest failures Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_CHROME_WEB_UI_FACTORY_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_CHROME_WEB_UI_FACTORY_H_
6 #define CHROME_BROWSER_UI_WEBUI_CHROME_WEB_UI_FACTORY_H_ 6 #define CHROME_BROWSER_UI_WEBUI_CHROME_WEB_UI_FACTORY_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/memory/singleton.h" 10 #include "base/memory/singleton.h"
11 #include "content/browser/webui/web_ui.h" 11 #include "content/browser/webui/web_ui.h"
12 #include "content/public/browser/web_ui_factory.h" 12 #include "content/public/browser/web_ui_factory.h"
13 #include "chrome/browser/favicon/favicon_service.h" 13 #include "chrome/browser/favicon/favicon_service.h"
14 14
15 class WebUI;
16 class GURL;
17 class Profile; 15 class Profile;
18 class RefCountedMemory; 16 class RefCountedMemory;
19 class TabContents;
20 17
21 class ChromeWebUIFactory : public content::WebUIFactory { 18 class ChromeWebUIFactory : public content::WebUIFactory {
22 public: 19 public:
23 virtual WebUI::TypeID GetWebUIType(content::BrowserContext* browser_context, 20 virtual WebUI::TypeID GetWebUIType(content::BrowserContext* browser_context,
24 const GURL& url) const OVERRIDE; 21 const GURL& url) const OVERRIDE;
25 virtual bool UseWebUIForURL(content::BrowserContext* browser_context, 22 virtual bool UseWebUIForURL(content::BrowserContext* browser_context,
26 const GURL& url) const OVERRIDE; 23 const GURL& url) const OVERRIDE;
27 virtual bool UseWebUIBindingsForURL(content::BrowserContext* browser_context, 24 virtual bool UseWebUIBindingsForURL(content::BrowserContext* browser_context,
28 const GURL& url) const OVERRIDE; 25 const GURL& url) const OVERRIDE;
29 virtual bool HasWebUIScheme(const GURL& url) const OVERRIDE; 26 virtual bool HasWebUIScheme(const GURL& url) const OVERRIDE;
30 virtual bool IsURLAcceptableForWebUI(content::BrowserContext* browser_context, 27 virtual bool IsURLAcceptableForWebUI(content::BrowserContext* browser_context,
31 const GURL& url) const OVERRIDE; 28 const GURL& url) const OVERRIDE;
32 virtual WebUI* CreateWebUIForURL(content::WebContents* tab_contents, 29 virtual content::WebUIController* CreateWebUIForURL(
33 const GURL& url) const OVERRIDE; 30 WebUI* web_ui,
31 const GURL& url) const OVERRIDE;
34 32
35 // Get the favicon for |page_url| and forward the result to the |request| 33 // Get the favicon for |page_url| and forward the result to the |request|
36 // when loaded. 34 // when loaded.
37 void GetFaviconForURL(Profile* profile, 35 void GetFaviconForURL(Profile* profile,
38 FaviconService::GetFaviconRequest* request, 36 FaviconService::GetFaviconRequest* request,
39 const GURL& page_url) const; 37 const GURL& page_url) const;
40 38
41 static ChromeWebUIFactory* GetInstance(); 39 static ChromeWebUIFactory* GetInstance();
42 40
43 protected: 41 protected:
44 ChromeWebUIFactory(); 42 ChromeWebUIFactory();
45 virtual ~ChromeWebUIFactory(); 43 virtual ~ChromeWebUIFactory();
46 44
47 private: 45 private:
48 46
49 friend struct DefaultSingletonTraits<ChromeWebUIFactory>; 47 friend struct DefaultSingletonTraits<ChromeWebUIFactory>;
50 48
51 // Gets the data for the favicon for a WebUI page. Returns NULL if the WebUI 49 // Gets the data for the favicon for a WebUI page. Returns NULL if the WebUI
52 // does not have a favicon. 50 // does not have a favicon.
53 RefCountedMemory* GetFaviconResourceBytes(const GURL& page_url) const; 51 RefCountedMemory* GetFaviconResourceBytes(const GURL& page_url) const;
54 52
55 DISALLOW_COPY_AND_ASSIGN(ChromeWebUIFactory); 53 DISALLOW_COPY_AND_ASSIGN(ChromeWebUIFactory);
56 }; 54 };
57 55
58 #endif // CHROME_BROWSER_UI_WEBUI_CHROME_WEB_UI_FACTORY_H_ 56 #endif // CHROME_BROWSER_UI_WEBUI_CHROME_WEB_UI_FACTORY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698