Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: chrome/browser/ui/webui/bookmarks_ui.h

Issue 9224002: Make WebUI objects not derive from WebUI. WebUI objects own the controller. This is the ownership... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync to head to clear linux_chromeos browsertest failures Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_BOOKMARKS_UI_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_BOOKMARKS_UI_H_
6 #define CHROME_BROWSER_UI_WEBUI_BOOKMARKS_UI_H_ 6 #define CHROME_BROWSER_UI_WEBUI_BOOKMARKS_UI_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
11 #include "chrome/browser/ui/webui/chrome_url_data_manager.h" 11 #include "chrome/browser/ui/webui/chrome_url_data_manager.h"
12 #include "content/browser/webui/web_ui.h"
13 #include "content/public/browser/web_ui_controller.h" 12 #include "content/public/browser/web_ui_controller.h"
14 13
15 class RefCountedMemory; 14 class RefCountedMemory;
16 15
17 // This class provides the source for chrome://bookmarks/ 16 // This class provides the source for chrome://bookmarks/
18 class BookmarksUIHTMLSource : public ChromeURLDataManager::DataSource { 17 class BookmarksUIHTMLSource : public ChromeURLDataManager::DataSource {
19 public: 18 public:
20 BookmarksUIHTMLSource(); 19 BookmarksUIHTMLSource();
21 20
22 // Called when the network layer has requested a resource underneath 21 // Called when the network layer has requested a resource underneath
23 // the path we registered. 22 // the path we registered.
24 virtual void StartDataRequest(const std::string& path, 23 virtual void StartDataRequest(const std::string& path,
25 bool is_incognito, 24 bool is_incognito,
26 int request_id) OVERRIDE; 25 int request_id) OVERRIDE;
27 virtual std::string GetMimeType(const std::string& path) const OVERRIDE; 26 virtual std::string GetMimeType(const std::string& path) const OVERRIDE;
28 27
29 private: 28 private:
30 DISALLOW_COPY_AND_ASSIGN(BookmarksUIHTMLSource); 29 DISALLOW_COPY_AND_ASSIGN(BookmarksUIHTMLSource);
31 }; 30 };
32 31
33 // This class is used to hook up chrome://bookmarks/ which in turn gets 32 // This class is used to hook up chrome://bookmarks/ which in turn gets
34 // overridden by an extension. 33 // overridden by an extension.
35 class BookmarksUI : public WebUI, public content::WebUIController { 34 class BookmarksUI : public content::WebUIController {
36 public: 35 public:
37 explicit BookmarksUI(content::WebContents* contents); 36 explicit BookmarksUI(WebUI* web_ui);
38 37
39 static RefCountedMemory* GetFaviconResourceBytes(); 38 static RefCountedMemory* GetFaviconResourceBytes();
40 39
41 private: 40 private:
42 DISALLOW_COPY_AND_ASSIGN(BookmarksUI); 41 DISALLOW_COPY_AND_ASSIGN(BookmarksUI);
43 }; 42 };
44 43
45 #endif // CHROME_BROWSER_UI_WEBUI_BOOKMARKS_UI_H_ 44 #endif // CHROME_BROWSER_UI_WEBUI_BOOKMARKS_UI_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698