run cygwin mount setup in runhooks, and remove some references to it

run cygwin mount setup in runhooks, and remove some references to it

BUG=111731
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119708

[scottmg, 2012-01-27 23:25:10]

Runs it in gclient runhooks/sync, and removes dependency from all Chromium
places.

I'll have to delete the target in a separate CL because there's references in
third_party/WebKit and third_party/ffmpeg.

[jam, 2012-01-28 00:06:57]

thanks so much for doing this! one comment

http://codereview.chromium.org/9223028/diff/3001/build/win/setup_cygwin_mount.py
File build/win/setup_cygwin_mount.py (right):

http://codereview.chromium.org/9223028/diff/3001/build/win/setup_cygwin_mount...
build/win/setup_cygwin_mount.py:15: return
os.system(os.path.normpath(batch_path) + ">nul")
I suspect it'll be much faster to do the registry operations here than to run a
bat file which runs reg.exe a bunch of times. it'll also reduce the need to run
an external bat file which I can't imagine is fast.

but if you time it and this is really short, then ignore this.

[scottmg, 2012-01-28 00:20:09]

http://codereview.chromium.org/9223028/diff/3001/build/win/setup_cygwin_mount.py
File build/win/setup_cygwin_mount.py (right):

http://codereview.chromium.org/9223028/diff/3001/build/win/setup_cygwin_mount...
build/win/setup_cygwin_mount.py:15: return
os.system(os.path.normpath(batch_path) + ">nul")
On 2012/01/28 00:06:57, John Abd-El-Malek wrote:
> I suspect it'll be much faster to do the registry operations here than to run
a
> bat file which runs reg.exe a bunch of times. it'll also reduce the need to
run
> an external bat file which I can't imagine is fast.
> 
> but if you time it and this is really short, then ignore this.

I get 0.34s. I'd lean towards not doing it so I don't break it (and since it's
during sync anyway), but I don't mind doing it if you think it's worth it.

[jam, 2012-01-28 01:38:22]

On 2012/01/28 00:20:09, scottmg wrote:
>
http://codereview.chromium.org/9223028/diff/3001/build/win/setup_cygwin_mount.py
> File build/win/setup_cygwin_mount.py (right):
> 
>
http://codereview.chromium.org/9223028/diff/3001/build/win/setup_cygwin_mount...
> build/win/setup_cygwin_mount.py:15: return
> os.system(os.path.normpath(batch_path) + ">nul")
> On 2012/01/28 00:06:57, John Abd-El-Malek wrote:
> > I suspect it'll be much faster to do the registry operations here than to
run
> a
> > bat file which runs reg.exe a bunch of times. it'll also reduce the need to
> run
> > an external bat file which I can't imagine is fast.
> > 
> > but if you time it and this is really short, then ignore this.
> 
> I get 0.34s. I'd lean towards not doing it so I don't break it (and since it's
> during sync anyway), but I don't mind doing it if you think it's worth it.

lgtm , we have much more lower hanging fruit :)

[e.mojarro11, 2016-03-17 07:42:11]

e.mojarro11@gmail.com changed reviewers:
+ e.mojarro11@gmail.com