Issue 9223016: Add a getter for value set with AllowCodeGenerationFromStrings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9223016: Add a getter for value set with AllowCodeGenerationFromStrings (Closed)

Created:
8 years, 11 months ago by yurys

Modified:
8 years, 10 months ago

Reviewers:
pfeldman, danno, loislo

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Add a getter for value set with AllowCodeGenerationFromStrings Committed: https://code.google.com/p/v8/source/detail?r=10578

Patch Set 3 : '' #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -0 lines)			Patch
M	include/v8.h	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/api.cc	View	1 2	1 chunk	+14 lines, -0 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

danno

LGTM with the name change http://codereview.chromium.org/9223016/diff/1/include/v8.h File include/v8.h (right): http://codereview.chromium.org/9223016/diff/1/include/v8.h#newcode3545 include/v8.h:3545: bool CodeGenerationFromStringsAllowed(); Should be ...

8 years, 10 months ago (2012-02-01 12:33:37 UTC) #2

yurys

8 years, 10 months ago (2012-02-01 12:58:08 UTC) #3

http://codereview.chromium.org/9223016/diff/1/include/v8.h
File include/v8.h (right):

http://codereview.chromium.org/9223016/diff/1/include/v8.h#newcode3545
include/v8.h:3545: bool CodeGenerationFromStringsAllowed();
On 2012/02/01 12:33:37, danno wrote:
> Should be called "IsCodeGenerateFromStringsAllowed()"

Done.

Expand Messages | Collapse Messages

Issue 9223016: Add a getter for value set with AllowCodeGenerationFromStrings (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages