Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1589)

Issue 9223010: Update harfbuzz-ng to 1a5a91dc0d8bf4b72a2f22dc6300b06ad7000b79. (Closed)

Created:
8 years, 11 months ago by bashi
Modified:
8 years, 10 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, jshin+watch_chromium.org, tony, behdad
Visibility:
Public.

Description

Update harfbuzz-ng to 1a5a91dc0d8bf4b72a2f22dc6300b06ad7000b79. Preparing for using HarfBuzz-ng as a secondary text shaper on mac. CoreText doesn't support OpenType features so we need additional text shaper to support -webkit-font-feature-settings property. I don't think this version is ready for transition on Linux because I could see considerable performance regressions when I run cycler tests. BUG=68551 TEST=None. This CL doesn't change build process for now. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119661

Patch Set 1 #

Patch Set 2 : Don't use -M option for 'git diff' to patch correctly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11541 lines, -9885 lines) Patch
M third_party/harfbuzz-ng/COPYING View 1 chunk +9 lines, -7 lines 0 comments Download
M third_party/harfbuzz-ng/README View 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/harfbuzz-ng/README.chromium View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/harfbuzz-ng/harfbuzz.gyp View 3 chunks +62 lines, -21 lines 0 comments Download
D third_party/harfbuzz-ng/src/Makefile.am View 1 chunk +0 lines, -147 lines 0 comments Download
D third_party/harfbuzz-ng/src/check-c-linkage-decls.sh View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/harfbuzz-ng/src/check-header-guards.sh View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/harfbuzz-ng/src/check-internal-symbols.sh View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/harfbuzz-ng/src/check-libstdc++.sh View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/harfbuzz-ng/src/gen-arabic-joining-table.py View 1 chunk +0 lines, -83 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-blob.h View 3 chunks +25 lines, -17 lines 0 comments Download
D third_party/harfbuzz-ng/src/hb-blob.c View 1 chunk +0 lines, -362 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-blob.cc View 1 chunk +324 lines, -0 lines 0 comments Download
D third_party/harfbuzz-ng/src/hb-blob-private.h View 1 chunk +0 lines, -59 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-buffer.h View 7 chunks +57 lines, -26 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-buffer.cc View 10 chunks +529 lines, -300 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-buffer-private.hh View 4 chunks +80 lines, -70 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-common.h View 4 chunks +255 lines, -39 lines 0 comments Download
D third_party/harfbuzz-ng/src/hb-common.c View 1 chunk +0 lines, -47 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-common.cc View 1 chunk +372 lines, -0 lines 0 comments Download
A + third_party/harfbuzz-ng/src/hb-fallback-shape.cc View 2 chunks +28 lines, -31 lines 0 comments Download
A + third_party/harfbuzz-ng/src/hb-fallback-shape-private.hh View 2 chunks +14 lines, -12 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-font.h View 5 chunks +242 lines, -109 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-font.cc View 14 chunks +631 lines, -226 lines 0 comments Download
D third_party/harfbuzz-ng/src/hb-font-private.h View 1 chunk +0 lines, -97 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-font-private.hh View 1 chunk +163 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ft.h View 3 chunks +11 lines, -5 lines 0 comments Download
D third_party/harfbuzz-ng/src/hb-ft.c View 1 chunk +0 lines, -262 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ft.cc View 1 chunk +439 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-glib.h View 2 chunks +11 lines, -1 line 0 comments Download
D third_party/harfbuzz-ng/src/hb-glib.c View 1 chunk +0 lines, -64 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-glib.cc View 1 chunk +349 lines, -0 lines 0 comments Download
A + third_party/harfbuzz-ng/src/hb-gobject.h View 2 chunks +30 lines, -20 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-gobject-enums.cc View 1 chunk +259 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-gobject-enums.cc.tmpl View 1 chunk +74 lines, -0 lines 0 comments Download
A + third_party/harfbuzz-ng/src/hb-gobject-structs.cc View 2 chunks +37 lines, -50 lines 0 comments Download
D third_party/harfbuzz-ng/src/hb-graphite.h View 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/harfbuzz-ng/src/hb-graphite.cc View 1 chunk +0 lines, -310 lines 0 comments Download
A + third_party/harfbuzz-ng/src/hb-graphite2.h View 3 chunks +12 lines, -13 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-graphite2.cc View 1 chunk +348 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-icu.h View 2 chunks +12 lines, -1 line 0 comments Download
D third_party/harfbuzz-ng/src/hb-icu.c View 1 chunk +0 lines, -260 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-icu.cc View 1 chunk +291 lines, -0 lines 0 comments Download
D third_party/harfbuzz-ng/src/hb-language.h View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/harfbuzz-ng/src/hb-language.c View 1 chunk +0 lines, -120 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-mutex-private.hh View 1 chunk +110 lines, -0 lines 0 comments Download
D third_party/harfbuzz-ng/src/hb-object-private.h View 1 chunk +0 lines, -141 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-object-private.hh View 1 chunk +267 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-open-file-private.hh View 6 chunks +4 lines, -6 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-open-type-private.hh View 14 chunks +79 lines, -96 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot.h View 1 chunk +1 line, -1 line 0 comments Download
D third_party/harfbuzz-ng/src/hb-ot-head-private.hh View 1 chunk +0 lines, -146 lines 0 comments Download
A + third_party/harfbuzz-ng/src/hb-ot-head-table.hh View 4 chunks +5 lines, -8 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-hhea-table.hh View 1 chunk +92 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-hmtx-table.hh View 1 chunk +86 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout.h View 5 chunks +16 lines, -5 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout.cc View 8 chunks +59 lines, -40 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-common-private.hh View 7 chunks +11 lines, -19 lines 0 comments Download
D third_party/harfbuzz-ng/src/hb-ot-layout-gdef-private.hh View 1 chunk +0 lines, -429 lines 0 comments Download
A + third_party/harfbuzz-ng/src/hb-ot-layout-gdef-table.hh View 13 chunks +30 lines, -32 lines 0 comments Download
D third_party/harfbuzz-ng/src/hb-ot-layout-gpos-private.hh View 1 chunk +0 lines, -1588 lines 0 comments Download
A + third_party/harfbuzz-ng/src/hb-ot-layout-gpos-table.hh View 29 chunks +249 lines, -227 lines 0 comments Download
D third_party/harfbuzz-ng/src/hb-ot-layout-gsub-private.hh View 1 chunk +0 lines, -931 lines 0 comments Download
A + third_party/harfbuzz-ng/src/hb-ot-layout-gsub-table.hh View 22 chunks +78 lines, -65 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-gsubgpos-private.hh View 21 chunks +141 lines, -66 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-private.hh View 4 chunks +27 lines, -43 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-map.cc View 6 chunks +136 lines, -56 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-map-private.hh View 3 chunks +105 lines, -57 lines 0 comments Download
A + third_party/harfbuzz-ng/src/hb-ot-maxp-table.hh View 2 chunks +28 lines, -26 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-name-table.hh View 1 chunk +129 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape.h View 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape.cc View 10 chunks +200 lines, -134 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic.cc View 5 chunks +57 lines, -24 lines 0 comments Download
D third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic-table.h View 1 chunk +0 lines, -674 lines 0 comments Download
A + third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic-table.hh View 10 chunks +204 lines, -120 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic.cc View 1 chunk +765 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic-machine.hh View 1 chunk +304 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic-machine.rl View 1 chunk +119 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic-table.hh View 1 chunk +830 lines, -0 lines 0 comments Download
A + third_party/harfbuzz-ng/src/hb-ot-shape-complex-misc.cc View 2 chunks +22 lines, -14 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-private.hh View 4 chunks +153 lines, -22 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-shape-normalize.cc View 1 chunk +286 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-private.hh View 3 chunks +66 lines, -13 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-tag.h View 3 chunks +5 lines, -4 lines 0 comments Download
D third_party/harfbuzz-ng/src/hb-ot-tag.c View 1 chunk +0 lines, -703 lines 0 comments Download
A + third_party/harfbuzz-ng/src/hb-ot-tag.cc View 8 chunks +191 lines, -184 lines 0 comments Download
D third_party/harfbuzz-ng/src/hb-private.h View 1 chunk +0 lines, -270 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-private.hh View 1 chunk +632 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-shape.h View 2 chunks +17 lines, -6 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-shape.cc View 2 chunks +113 lines, -23 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-tt-font.cc View 1 chunk +242 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-unicode.h View 4 chunks +106 lines, -206 lines 0 comments Download
D third_party/harfbuzz-ng/src/hb-unicode.c View 1 chunk +0 lines, -364 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-unicode.cc View 1 chunk +273 lines, -0 lines 0 comments Download
D third_party/harfbuzz-ng/src/hb-unicode-private.h View 1 chunk +0 lines, -64 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-unicode-private.hh View 1 chunk +107 lines, -0 lines 0 comments Download
A + third_party/harfbuzz-ng/src/hb-uniscribe.h View 2 chunks +24 lines, -10 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-uniscribe.cc View 1 chunk +463 lines, -0 lines 0 comments Download
A + third_party/harfbuzz-ng/src/hb-version.h View 2 chunks +25 lines, -9 lines 0 comments Download
M third_party/harfbuzz-ng/src/main.cc View 4 chunks +3 lines, -5 lines 0 comments Download
D third_party/harfbuzz-ng/src/test.c View 1 chunk +0 lines, -94 lines 0 comments Download
M third_party/harfbuzz/harfbuzz.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bashi
Hi Evan, Files to be reviewed: - third_party/harfbuzz-ng/README.chromium - third_party/harfbuzz-ng/harfbuzz.gyp - third_party/harfbuzz/harfbuzz.gyp I'd like to ...
8 years, 11 months ago (2012-01-27 08:00:21 UTC) #1
Evan Martin
LGTM
8 years, 11 months ago (2012-01-27 16:21:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bashi@chromium.org/9223010/1
8 years, 10 months ago (2012-01-29 06:06:10 UTC) #3
commit-bot: I haz the power
Can't apply patch for file third_party/harfbuzz-ng/src/hb-fallback-shape-private.hh. While running patch -p1 --forward --force; patching file third_party/harfbuzz-ng/src/hb-fallback-shape-private.hh
8 years, 10 months ago (2012-01-29 06:06:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bashi@chromium.org/9223010/1
8 years, 10 months ago (2012-01-29 23:48:05 UTC) #5
commit-bot: I haz the power
8 years, 10 months ago (2012-01-29 23:48:34 UTC) #6
Can't apply patch for file
third_party/harfbuzz-ng/src/hb-fallback-shape-private.hh.
While running patch -p1 --forward --force;
patching file third_party/harfbuzz-ng/src/hb-fallback-shape-private.hh

Powered by Google App Engine
This is Rietveld 408576698