Issue 9223005: Remove pointer mangling API from trace_event.h and use an addTraceEvent flag instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9223005: Remove pointer mangling API from trace_event.h and use an addTraceEvent flag instead (Closed)

Created:
8 years, 11 months ago by jbates

Modified:
8 years, 11 months ago

Reviewers:
darin (slow to review), nduca

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove pointer mangling API from trace_event.h and use an addTraceEvent flag instead BUG=109779 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119519

Patch Set 1 #

Patch Set 2 : using unused parameters #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -53 lines)			Patch
M	base/debug/trace_event.h	View	1	7 chunks	+48 lines, -40 lines	0 comments	Download
M	base/debug/trace_event_impl.h	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	base/debug/trace_event_impl.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/glue/webkitplatformsupport_impl.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/glue/webkitplatformsupport_impl.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jbates

Simplified the required tracing API by moving the pointer mangling logic into addTraceEvent. No new ...

8 years, 11 months ago (2012-01-27 01:39:08 UTC) #1

darin (slow to review)

LGTM for webkit/, and I defer to nduca for base/trace_event* changes.

8 years, 11 months ago (2012-01-27 07:25:15 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbates@chromium.org/9223005/2001

8 years, 11 months ago (2012-01-27 17:51:26 UTC) #5

commit-bot: I haz the power

8 years, 11 months ago (2012-01-27 20:23:43 UTC) #6

Try job failure for 9223005-2001 (retry) on mac_rel for steps "browser_tests,
ui_tests".
It's a second try, previously, steps "browser_tests, ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Expand Messages | Collapse Messages