Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: ui/gfx/compositor/layer_animator_unittest.cc

Issue 9222018: reland -- Disable animations during aura tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address reviewer comments. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/compositor/layer_animator_unittest.cc
diff --git a/ui/gfx/compositor/layer_animator_unittest.cc b/ui/gfx/compositor/layer_animator_unittest.cc
index cad4a6b555e2adf338db41b5d152513992ca9ad8..f3318fe35ca4da37cffd122bfb13f498b7bd26be 100644
--- a/ui/gfx/compositor/layer_animator_unittest.cc
+++ b/ui/gfx/compositor/layer_animator_unittest.cc
@@ -133,7 +133,7 @@ TEST(LayerAnimatorTest, ScheduleAnimationThatCanRunImmediately) {
EXPECT_TRUE(animator->is_animating());
EXPECT_FLOAT_EQ(delegate.GetOpacityForAnimation(), start_opacity);
- base::TimeTicks start_time = animator->get_last_step_time_for_test();
+ base::TimeTicks start_time = animator->last_step_time();
element->Step(start_time + base::TimeDelta::FromMilliseconds(500));
@@ -181,7 +181,7 @@ TEST(LayerAnimatorTest, ScheduleTwoAnimationsThatCanRunImmediately) {
EXPECT_FLOAT_EQ(delegate.GetOpacityForAnimation(), start_opacity);
CheckApproximatelyEqual(delegate.GetBoundsForAnimation(), start_bounds);
- base::TimeTicks start_time = animator->get_last_step_time_for_test();
+ base::TimeTicks start_time = animator->last_step_time();
element->Step(start_time + base::TimeDelta::FromMilliseconds(500));
@@ -224,7 +224,7 @@ TEST(LayerAnimatorTest, ScheduleTwoAnimationsOnSameProperty) {
EXPECT_TRUE(animator->is_animating());
EXPECT_FLOAT_EQ(delegate.GetOpacityForAnimation(), start_opacity);
- base::TimeTicks start_time = animator->get_last_step_time_for_test();
+ base::TimeTicks start_time = animator->last_step_time();
element->Step(start_time + base::TimeDelta::FromMilliseconds(500));
@@ -292,7 +292,7 @@ TEST(LayerAnimatorTest, ScheduleBlockedAnimation) {
EXPECT_FLOAT_EQ(delegate.GetOpacityForAnimation(), start_opacity);
CheckApproximatelyEqual(delegate.GetBoundsForAnimation(), start_bounds);
- base::TimeTicks start_time = animator->get_last_step_time_for_test();
+ base::TimeTicks start_time = animator->last_step_time();
element->Step(start_time + base::TimeDelta::FromMilliseconds(500));
@@ -364,7 +364,7 @@ TEST(LayerAnimatorTest, ScheduleTogether) {
EXPECT_FLOAT_EQ(delegate.GetOpacityForAnimation(), start_opacity);
CheckApproximatelyEqual(delegate.GetBoundsForAnimation(), start_bounds);
- base::TimeTicks start_time = animator->get_last_step_time_for_test();
+ base::TimeTicks start_time = animator->last_step_time();
element->Step(start_time + base::TimeDelta::FromMilliseconds(1000));
@@ -403,7 +403,7 @@ TEST(LayerAnimatorTest, StartAnimationThatCanRunImmediately) {
EXPECT_TRUE(animator->is_animating());
EXPECT_FLOAT_EQ(delegate.GetOpacityForAnimation(), start_opacity);
- base::TimeTicks start_time = animator->get_last_step_time_for_test();
+ base::TimeTicks start_time = animator->last_step_time();
element->Step(start_time + base::TimeDelta::FromMilliseconds(500));
@@ -467,7 +467,7 @@ TEST(LayerAnimatorTest, PreemptByImmediatelyAnimatingToNewTarget) {
new LayerAnimationSequence(
LayerAnimationElement::CreateOpacityElement(target_opacity, delta)));
- base::TimeTicks start_time = animator->get_last_step_time_for_test();
+ base::TimeTicks start_time = animator->last_step_time();
element->Step(start_time + base::TimeDelta::FromMilliseconds(500));
@@ -518,7 +518,7 @@ TEST(LayerAnimatorTest, PreemptEnqueueNewAnimation) {
new LayerAnimationSequence(
LayerAnimationElement::CreateOpacityElement(target_opacity, delta)));
- base::TimeTicks start_time = animator->get_last_step_time_for_test();
+ base::TimeTicks start_time = animator->last_step_time();
element->Step(start_time + base::TimeDelta::FromMilliseconds(500));
@@ -571,7 +571,7 @@ TEST(LayerAnimatorTest, PreemptyByReplacingQueuedAnimations) {
new LayerAnimationSequence(
LayerAnimationElement::CreateOpacityElement(target_opacity, delta)));
- base::TimeTicks start_time = animator->get_last_step_time_for_test();
+ base::TimeTicks start_time = animator->last_step_time();
element->Step(start_time + base::TimeDelta::FromMilliseconds(500));
@@ -630,7 +630,7 @@ TEST(LayerAnimatorTest, CyclicSequences) {
animator->StartAnimation(sequence.release());
- base::TimeTicks start_time = animator->get_last_step_time_for_test();
+ base::TimeTicks start_time = animator->last_step_time();
element->Step(start_time + base::TimeDelta::FromMilliseconds(1000));
@@ -687,7 +687,7 @@ TEST(LayerAnimatorTest, AddObserverExplicit) {
EXPECT_EQ(observer.last_scheduled_sequence(), sequence);
- base::TimeTicks start_time = animator->get_last_step_time_for_test();
+ base::TimeTicks start_time = animator->last_step_time();
element->Step(start_time + base::TimeDelta::FromMilliseconds(1000));
@@ -729,7 +729,7 @@ TEST(LayerAnimatorTest, AddObserverImplicit) {
scoped_observer = TestLayerAnimationObserver();
EXPECT_TRUE(!scoped_observer.last_ended_sequence());
animator->SetOpacity(1.0f);
- start_time = animator->get_last_step_time_for_test();
+ start_time = animator->last_step_time();
element->Step(start_time + base::TimeDelta::FromMilliseconds(1000));
EXPECT_FALSE(!scoped_observer.last_ended_sequence());
}
@@ -758,12 +758,12 @@ TEST(LayerAnimatorTest, ImplicitAnimationObservers) {
{
ScopedLayerAnimationSettings settings(animator.get());
- settings.AddImplicitObserver(&observer);
+ settings.AddObserver(&observer);
animator->SetOpacity(0.0f);
}
EXPECT_FALSE(observer.animations_completed());
- base::TimeTicks start_time = animator->get_last_step_time_for_test();
+ base::TimeTicks start_time = animator->last_step_time();
element->Step(start_time + base::TimeDelta::FromMilliseconds(1000));
EXPECT_TRUE(observer.animations_completed());
EXPECT_FLOAT_EQ(0.0f, delegate.GetOpacityForAnimation());
@@ -783,7 +783,7 @@ TEST(LayerAnimatorTest, InterruptedImplicitAnimationObservers) {
{
ScopedLayerAnimationSettings settings(animator.get());
- settings.AddImplicitObserver(&observer);
+ settings.AddObserver(&observer);
animator->SetOpacity(0.0f);
}
@@ -822,7 +822,7 @@ TEST(LayerAnimatorTest, RemoveObserverShouldRemoveFromSequences) {
// This should stop the observer from observing sequence.
animator->RemoveObserver(&removed_observer);
- base::TimeTicks start_time = animator->get_last_step_time_for_test();
+ base::TimeTicks start_time = animator->last_step_time();
element->Step(start_time + base::TimeDelta::FromMilliseconds(1000));

Powered by Google App Engine
This is Rietveld 408576698