Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2620)

Unified Diff: chrome/browser/io_thread.cc

Issue 9221008: Move cleanup that happens on IO thread destruction to content, so that not every embedder has to ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_process_impl.cc ('k') | content/browser/browser_process_sub_thread.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/io_thread.cc
===================================================================
--- chrome/browser/io_thread.cc (revision 117868)
+++ chrome/browser/io_thread.cc (working copy)
@@ -32,8 +32,6 @@
#include "chrome/browser/prefs/pref_service.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/pref_names.h"
-#include "content/browser/gpu/gpu_process_host.h"
-#include "content/browser/in_process_webkit/indexed_db_key_utility_client.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/common/content_client.h"
#include "content/public/common/url_fetcher.h"
@@ -478,27 +476,14 @@
delete sdch_manager_;
sdch_manager_ = NULL;
- // Step 1: Kill all things that might be holding onto
- // net::URLRequest/net::URLRequestContexts.
-
#if defined(USE_NSS)
net::ShutdownOCSP();
#endif // defined(USE_NSS)
- // Destroy all URLRequests started by URLFetchers.
- content::URLFetcher::CancelAll();
-
- IndexedDBKeyUtilityClient::Shutdown();
-
- // If any child processes are still running, terminate them and
- // and delete the BrowserChildProcessHost instances to release whatever
- // IO thread only resources they are referencing.
- BrowserChildProcessHost::TerminateAll();
-
system_url_request_context_getter_ = NULL;
- // Step 2: Release objects that the net::URLRequestContext could have been
- // pointing to.
+ // Release objects that the net::URLRequestContext could have been pointing
+ // to.
// This must be reset before the ChromeNetLog is destroyed.
network_change_observer_.reset();
@@ -508,9 +493,6 @@
delete globals_;
globals_ = NULL;
- // net::URLRequest instances must NOT outlive the IO thread.
- base::debug::LeakTracker<net::URLRequest>::CheckForLeaks();
-
base::debug::LeakTracker<SystemURLRequestContextGetter>::CheckForLeaks();
}
« no previous file with comments | « chrome/browser/browser_process_impl.cc ('k') | content/browser/browser_process_sub_thread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698