Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Unified Diff: client/dom/scripts/dartgenerator.py

Issue 9221006: Move frog dart:dom from fields to getters/setters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: comment Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/dom/generated/src/frog/XPathResult.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/dom/scripts/dartgenerator.py
diff --git a/client/dom/scripts/dartgenerator.py b/client/dom/scripts/dartgenerator.py
index 92f80da59e48c4e79f6dc1c3b9f160f956c6fcee..6fb73267d38b300513a086a135ad9c1d9e0a1810 100755
--- a/client/dom/scripts/dartgenerator.py
+++ b/client/dom/scripts/dartgenerator.py
@@ -1929,16 +1929,16 @@ class FrogInterfaceGenerator(object):
pass
def AddGetter(self, attr):
- # Declare as a field in the native class.
- # TODO(vsm): Mark this as native somehow.
+ # TODO(sra): Remove native body when Issue 829 fixed.
self._members_emitter.Emit(
- '\n'
- ' $TYPE $NAME;\n',
- NAME=attr.id, TYPE=attr.type.id, INTERFACE=self._interface.id)
+ '\n $TYPE get $NAME() native "return this.$NAME;";\n',
+ NAME=attr.id, TYPE=attr.type.id)
def AddSetter(self, attr):
- # TODO(vsm): Suppress for now. Should emit if there is no getter.
- pass
+ # TODO(sra): Remove native body when Issue 829 fixed.
+ self._members_emitter.Emit(
+ '\n void set $NAME($TYPE value) native "this.$NAME = value;";\n',
+ NAME=attr.id, TYPE=attr.type.id)
def AddSecondaryGetter(self, interface, attr):
self._SecondaryContext(interface)
« no previous file with comments | « client/dom/generated/src/frog/XPathResult.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698