Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 9220007: Merge 104140 - WebKit adds vertical paddings and borders to the fixed width of CSS tables (Closed)

Created:
8 years, 11 months ago by kerz_chromium
Modified:
8 years, 11 months ago
Reviewers:
commit-queue
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/963/
Visibility:
Public.

Description

Merge 104140 - WebKit adds vertical paddings and borders to the fixed width of CSS tables https://bugs.webkit.org/show_bug.cgi?id=74955 Patch by Max Vujovic <mvujovic@adobe.com>; on 2012-01-05 Reviewed by Julien Chaffraix. Source/WebCore: Test: fast/table/css-table-width.html * rendering/RenderTable.cpp: (WebCore::RenderTable::computeLogicalWidth): Changed the width calculation for CSS tables to take into account horizontal paddings and borders instead of vertical paddings and borders. LayoutTests: Added tests to check that the fixed width style is applied correctly to CSS tables with respect to table paddings and borders. * fast/table/css-table-width-expected.txt: Added. * fast/table/css-table-width.html: Added. * fast/table/script-tests/css-table-width.js: Added. (computeCSSTableOffsetWidth): (computeCSSTableOffsetHeight): (computeCSSTableProperty): TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=105208

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -4 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +18 lines, -1 line 0 comments Download
A + LayoutTests/fast/table/css-table-width.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/table/css-table-width-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/table/script-tests/css-table-width.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/ChangeLog View 1 chunk +16 lines, -1 line 0 comments Download
M Source/WebCore/rendering/RenderTable.cpp View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
kerz_chromium
8 years, 11 months ago (2012-01-18 00:13:03 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698