Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: ppapi/tests/test_flash_clipboard.cc

Issue 9212066: Modified the flash cipboard interface to add html clipboard support. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/tests/test_flash_clipboard.h ('k') | ppapi/thunk/ppb_flash_clipboard_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/tests/test_flash_clipboard.cc
diff --git a/ppapi/tests/test_flash_clipboard.cc b/ppapi/tests/test_flash_clipboard.cc
index 3022705cc98a6873c677a4d17fd4b7cdc84d1acd..2dfa0c5f28367a73efa2f57ccfa77452a72e8161 100644
--- a/ppapi/tests/test_flash_clipboard.cc
+++ b/ppapi/tests/test_flash_clipboard.cc
@@ -11,6 +11,12 @@
REGISTER_TEST_CASE(FlashClipboard);
+// WriteData() sends an async request to the browser process. As a result, the
+// string written may not be reflected by IsFormatAvailable() or ReadPlainText()
+// immediately. We need to wait and retry.
+const int kIntervalMs = 250;
+const int kMaxIntervals = kActionTimeoutMs / kIntervalMs;
+
TestFlashClipboard::TestFlashClipboard(TestingInstance* instance)
: TestCase(instance),
clipboard_interface_(NULL) {
@@ -23,48 +29,116 @@ bool TestFlashClipboard::Init() {
}
void TestFlashClipboard::RunTests(const std::string& filter) {
- RUN_TEST(ReadWrite, filter);
+ RUN_TEST(ReadWritePlainText, filter);
+ RUN_TEST(ReadWriteHTML, filter);
+ RUN_TEST(ReadWriteMultipleFormats, filter);
}
-std::string TestFlashClipboard::TestReadWrite() {
- std::string input_str("Hello, world");
- pp::Var input_var(input_str);
- clipboard_interface_->WritePlainText(instance_->pp_instance(),
- PP_FLASH_CLIPBOARD_TYPE_STANDARD,
- input_var.pp_var());
-
- // WritePlainText() causes an async request sent to the browser process.
- // As a result, the string written may not be reflected by IsFormatAvailable()
- // or ReadPlainText() immediately. We need to wait and retry.
- const int kIntervalMs = 250;
- const int kMaxIntervals = kActionTimeoutMs / kIntervalMs;
-
+PP_Bool TestFlashClipboard::IsFormatAvailable(
+ PP_Flash_Clipboard_Format format) {
PP_Bool is_available = PP_FALSE;
for (int i = 0; i < kMaxIntervals; ++i) {
is_available = clipboard_interface_->IsFormatAvailable(
instance_->pp_instance(),
PP_FLASH_CLIPBOARD_TYPE_STANDARD,
- PP_FLASH_CLIPBOARD_FORMAT_PLAINTEXT);
+ format);
if (is_available)
break;
PlatformSleep(kIntervalMs);
}
- ASSERT_TRUE(is_available);
+ return is_available;
+}
+std::string TestFlashClipboard::ReadStringVar(
+ PP_Flash_Clipboard_Format format) {
std::string result_str;
- for (int i = 0; i < kMaxIntervals; ++i) {
- pp::Var result_var(pp::Var::PassRef(),
- clipboard_interface_->ReadPlainText(instance_->pp_instance(),
- PP_FLASH_CLIPBOARD_TYPE_STANDARD));
- ASSERT_TRUE(result_var.is_string());
+ pp::Var result_var(
+ pp::Var::PassRef(),
+ clipboard_interface_->ReadData(instance_->pp_instance(),
+ PP_FLASH_CLIPBOARD_TYPE_STANDARD,
+ format));
+ if (result_var.is_string())
result_str = result_var.AsString();
- if (result_str == input_str)
- break;
+ return result_str;
+}
+int32_t TestFlashClipboard::WriteStringVar(PP_Flash_Clipboard_Format format,
+ const std::string& input) {
+ pp::Var input_var(input);
+ PP_Var data_item = input_var.pp_var();
+ int32_t success = clipboard_interface_->WriteData(
+ instance_->pp_instance(),
+ PP_FLASH_CLIPBOARD_TYPE_STANDARD,
+ 1,
+ &format,
+ &data_item);
+ return success;
+}
+
+bool TestFlashClipboard::ReadAndMatchPlainText(const std::string& input) {
+ for (int i = 0; i < kMaxIntervals; ++i) {
+ if (ReadStringVar(PP_FLASH_CLIPBOARD_FORMAT_PLAINTEXT) == input) {
+ return true;
+ }
PlatformSleep(kIntervalMs);
}
+ return false;
+}
+
+bool TestFlashClipboard::ReadAndMatchHTML(const std::string& input) {
+ for (int i = 0; i < kMaxIntervals; ++i) {
+ std::string result = ReadStringVar(PP_FLASH_CLIPBOARD_FORMAT_HTML);
+ // Markup is inserted around the copied html, so just check that
+ // the pasted string contains the copied string.
+ bool match = result.find(input) != std::string::npos;
+ if (match) {
+ return true;
+ }
+ PlatformSleep(kIntervalMs);
+ }
+ return false;
+}
+
+std::string TestFlashClipboard::TestReadWritePlainText() {
+ std::string input = "Hello world plain text!";
+ ASSERT_TRUE(WriteStringVar(PP_FLASH_CLIPBOARD_FORMAT_PLAINTEXT,
+ input) == PP_OK);
+ ASSERT_TRUE(IsFormatAvailable(PP_FLASH_CLIPBOARD_FORMAT_PLAINTEXT));
+ ASSERT_TRUE(ReadAndMatchPlainText(input));
+
+ PASS();
+}
+
+std::string TestFlashClipboard::TestReadWriteHTML() {
+ std::string input = "Hello world html!";
+ ASSERT_TRUE(WriteStringVar(PP_FLASH_CLIPBOARD_FORMAT_HTML,
+ input) == PP_OK);
+ ASSERT_TRUE(IsFormatAvailable(PP_FLASH_CLIPBOARD_FORMAT_HTML));
+ ASSERT_TRUE(ReadAndMatchHTML(input));
+
+ PASS();
+}
+
+std::string TestFlashClipboard::TestReadWriteMultipleFormats() {
+ pp::Var plain_text_var("plain text");
+ pp::Var html_var("html");
+ PP_Flash_Clipboard_Format formats[] =
+ { PP_FLASH_CLIPBOARD_FORMAT_PLAINTEXT, PP_FLASH_CLIPBOARD_FORMAT_HTML };
+ PP_Var data_items[] = { plain_text_var.pp_var(), html_var.pp_var() };
+ int32_t success = clipboard_interface_->WriteData(
+ instance_->pp_instance(),
+ PP_FLASH_CLIPBOARD_TYPE_STANDARD,
+ sizeof(data_items) / sizeof(*data_items),
+ formats,
+ data_items);
+ ASSERT_TRUE(success == PP_OK);
+
+ ASSERT_TRUE(IsFormatAvailable(PP_FLASH_CLIPBOARD_FORMAT_PLAINTEXT));
+ ASSERT_TRUE(IsFormatAvailable(PP_FLASH_CLIPBOARD_FORMAT_HTML));
+
+ ASSERT_TRUE(ReadAndMatchPlainText(plain_text_var.AsString()));
+ ASSERT_TRUE(ReadAndMatchHTML(html_var.AsString()));
- ASSERT_TRUE(result_str == input_str);
PASS();
}
« no previous file with comments | « ppapi/tests/test_flash_clipboard.h ('k') | ppapi/thunk/ppb_flash_clipboard_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698