Issue 9212049: Fix duplicate OFFICIAL_BUILD macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9212049: Fix duplicate OFFICIAL_BUILD macros. (Closed)

Created:
8 years, 11 months ago by Ivan Korotkov

Modified:
8 years, 10 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix duplicate OFFICIAL_BUILD macros. BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119893

Patch Set 1 #

Patch Set 2 : License year fix. #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chrome/common/chrome_version_info.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
	M	chrome/common/chrome_version_info_posix.h.version	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Korotkov

There is OFFICIAL_BUILD macro passed on the command line and under some circumstances (for me ...

8 years, 11 months ago (2012-01-25 11:14:28 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/9212049/1

8 years, 10 months ago (2012-01-31 12:00:54 UTC) #3

commit-bot: I haz the power

8 years, 10 months ago (2012-01-31 14:05:01 UTC) #4

Try job failure for 9212049-1 (retry) on mac_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Expand Messages | Collapse Messages