Add GetBoundAddress to PPB_UDPSocket_Private

ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_udp_socket_private_rpc_server.cc

Index: ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_udp_socket_private_rpc_server.cc
diff --git a/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_udp_socket_private_rpc_server.cc b/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_udp_socket_private_rpc_server.cc
index ccb46a2de394ed908b709e3faa9254842edd003b..300e63bb9604cc364ad4087729ab06c7d5161748 100644
--- a/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_udp_socket_private_rpc_server.cc
+++ b/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_udp_socket_private_rpc_server.cc
@@ -87,6 +87,31 @@ void PpbUDPSocketPrivateRpcServer::PPB_UDPSocket_Private_Bind(
   rpc->result = NACL_SRPC_RESULT_OK;
 }
 
+void PpbUDPSocketPrivateRpcServer::PPB_UDPSocket_Private_GetBoundAddress(
+    NaClSrpcRpc* rpc,
+    NaClSrpcClosure* done,
+    // input
+    PP_Resource udp_socket,
+    // output
+    nacl_abi_size_t* addr_bytes, char* addr,
+    int32_t* success) {
+  NaClSrpcClosureRunner runner(done);
+  rpc->result = NACL_SRPC_RESULT_APP_ERROR;
+
+  if (*addr_bytes !=
+      static_cast<nacl_abi_size_t>(sizeof(PP_NetAddress_Private)))
+    return;
+
+  PP_Bool pp_success =
+      PPBUDPSocketPrivateInterface()->GetBoundAddress(
+          udp_socket,
+          reinterpret_cast<PP_NetAddress_Private*>(addr));

[dmichael (off chromium), 2012/02/08 16:05:20]

nit: static_cast

[mtilburg1, 2012/02/09 11:08:06]

Michael- I'm not sure this is correct, PP_NetAddress_Private is a struct that
has an int and a char[].  plus, when I change to static cast, we do not compile.

[dmichael (off chromium), 2012/02/09 16:31:11]

You're right, I was assuming addr was void* without looking. Because it's char*,
you need reinterpret_cast.

(passing a stack-allocated struct and then memcpying from it would be safer to
guarantee correct alignment. But we have these reinterpret_casts all over the
place in the NaCl proxy, so SRPC already has to align it conservatively. What
you have is good.)

+  *success = PP_ToBool(pp_success);
+  DebugPrintf("PPB_UDPSocket_Private::GetBoundAddress: "
+              "success=%d\n", *success);

[dmichael (off chromium), 2012/02/08 16:05:20]

You should use NACL_PRId32 for int32_t, not %d.

[mtilburg1, 2012/02/09 11:08:06]

Done.

+  rpc->result = NACL_SRPC_RESULT_OK;
+}
+
 void PpbUDPSocketPrivateRpcServer::PPB_UDPSocket_Private_RecvFrom(
     NaClSrpcRpc* rpc,
     NaClSrpcClosure* done,