Add GetBoundAddress to PPB_UDPSocket_Private

ppapi/api/private/ppb_udp_socket_private.idl

 /* Copyright (c) 2012 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /**
  * This file defines the <code>PPB_UDPSocket_Private</code> interface.
  */
 
 label Chrome {
   M17 = 0.2
 };
 
 interface PPB_UDPSocket_Private {
   /**
    * Creates a UDP socket resource.
    */
   PP_Resource Create([in] PP_Instance instance_id);
 
   /**
    * Determines if a given resource is a UDP socket.
    */
   PP_Bool IsUDPSocket([in] PP_Resource resource_id);
 
   /* Creates a socket and binds to the address given by |addr|. */
   int32_t Bind([in] PP_Resource udp_socket,
                [in] PP_NetAddress_Private addr,
                [in] PP_CompletionCallback callback);
 
+  /* Upon successful completion of Bind, the address that we have
+   * bound to is stored in |addr|

[yzshen1, 2012/02/06 06:51:27]

Nit: This comment is inaccurate. The address is not stored in |addr| upon
successful completion of Bind. It should be something like: "Returns the address
that the socket has bound to. It won't succeed unless Bind has completed
successfully."

[mtilburg1, 2012/02/06 15:11:35]

Done.

+   */
+  PP_Bool GetBoundAddress([in] PP_Resource udp_socket,

[yzshen1, 2012/02/06 06:51:27]

You need to consider backward compatibility. This method should be in a newer
interface, say, 0.3. It has all methods from the older version, plus the new
one.

And you need to return 0.2 or 0.3 interface according to what the plugin asks
for.

http://codereview.chromium.org/9307115/ is an example of adding new methods
while maintaining backward compatibility.

[mtilburg1, 2012/02/06 15:11:35]

I added M18 = 0.3.... is this correct?  When I added M17 = 0.3, generating the
header file did not have the same effect(only version 0.3 was generated, no
0.2), but I'm not M18 is correct either???
On 2012/02/06 06:51:27, yzshen1 wrote:

[yzshen1, 2012/02/06 18:12:50]

Please use M19.

+                          [out] PP_NetAddress_Private addr);
+
   /* Performs a non-blocking recvfrom call on socket.
    * Bind must be called first. |callback| is invoked when recvfrom
    * reads data.  You must call GetRecvFromAddress to recover the
    * address the data was retrieved from.
    */
   int32_t RecvFrom([in] PP_Resource udp_socket,
                    [out] str_t buffer,
                    [in] int32_t num_bytes,
                    [in] PP_CompletionCallback callback);
 
   /* Upon successful completion of RecvFrom, the address that the data
    * was received from is stored in |addr|.
    */
   PP_Bool GetRecvFromAddress([in] PP_Resource udp_socket,
                              [out] PP_NetAddress_Private addr);
 
   /* Performs a non-blocking sendto call on the socket created and
    * bound(has already called Bind).  The callback |callback| is
    * invoked when sendto completes.
    */
   int32_t SendTo([in] PP_Resource udp_socket,
                  [in] str_t buffer,
                  [in] int32_t num_bytes,
                  [in] PP_NetAddress_Private addr,
                  [in] PP_CompletionCallback callback);
 
   /* Cancels all pending reads and writes, and closes the socket. */
   void Close([in] PP_Resource udp_socket);
 };