Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 9212044: Improving `content_security_policy` documentation. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 6 months ago by Mike West
Modified:
5 years, 5 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org
Visibility:
Public.

Description

Improving `content_security_policy` documentation. Added a document just for `content_security_policy` explaining the default restrictions, and offering pointers regarding best practice. Also updated the Analytics example and documentation accordingly. BUG=111049 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119211

Patch Set 1 #

Total comments: 4

Patch Set 2 : Adam's feedback. #

Patch Set 3 : Adding note about setTimeout and strings. #

Total comments: 12

Patch Set 4 : Meggin's feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+661 lines, -385 lines) Patch
A + chrome/common/extensions/docs/contentSecurityPolicy.html View 1 2 3 4 chunks +218 lines, -157 lines 0 comments Download
M chrome/common/extensions/docs/examples/tutorials/analytics.zip View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/common/extensions/docs/examples/tutorials/analytics/analytics.js View 1 chunk +0 lines, -32 lines 0 comments Download
M chrome/common/extensions/docs/examples/tutorials/analytics/manifest.json View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/examples/tutorials/analytics/popup.html View 2 chunks +8 lines, -17 lines 0 comments Download
A chrome/common/extensions/docs/examples/tutorials/analytics/popup.js View 1 2 3 1 chunk +49 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/manifest.html View 1 3 chunks +1 line, -44 lines 0 comments Download
M chrome/common/extensions/docs/samples.html View 1 2 3 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/samples.json View 1 2 3 2 chunks +4 lines, -5 lines 0 comments Download
A chrome/common/extensions/docs/static/contentSecurityPolicy.html View 1 2 3 1 chunk +272 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/static/manifest.html View 1 2 chunks +1 line, -42 lines 0 comments Download
M chrome/common/extensions/docs/static/tut_analytics.html View 5 chunks +50 lines, -39 lines 0 comments Download
M chrome/common/extensions/docs/tut_analytics.html View 1 4 chunks +51 lines, -39 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 8 (0 generated)
Mike West
Hi Adam, Meggin, and Ernest! I've made a bunch of changes to the CSP documentation, ...
5 years, 6 months ago (2012-01-24 12:22:55 UTC) #1
abarth-chromium
Technical content LGTM http://codereview.chromium.org/9212044/diff/1/chrome/common/extensions/docs/contentSecurityPolicy.html File chrome/common/extensions/docs/contentSecurityPolicy.html (right): http://codereview.chromium.org/9212044/diff/1/chrome/common/extensions/docs/contentSecurityPolicy.html#newcode308 chrome/common/extensions/docs/contentSecurityPolicy.html:308: <a href="#H3-1">Inline JavaScript will not be ...
5 years, 6 months ago (2012-01-24 16:42:36 UTC) #2
Mike West
Incorporated Adam's feedback, and restaged http://www.corp.google.com/~mkwst/no_crawl/docs/contentSecurityPolicy.html Thanks! http://codereview.chromium.org/9212044/diff/1/chrome/common/extensions/docs/contentSecurityPolicy.html File chrome/common/extensions/docs/contentSecurityPolicy.html (right): http://codereview.chromium.org/9212044/diff/1/chrome/common/extensions/docs/contentSecurityPolicy.html#newcode308 chrome/common/extensions/docs/contentSecurityPolicy.html:308: <a href="#H3-1">Inline ...
5 years, 6 months ago (2012-01-25 16:08:29 UTC) #3
mkearney
I like this doc - the before and after code samples are very cool. http://codereview.chromium.org/9212044/diff/9001/chrome/common/extensions/docs/static/contentSecurityPolicy.html ...
5 years, 6 months ago (2012-01-25 22:39:22 UTC) #4
Mike West
Thanks Meggin! Revisions attached and staged (same URL: http://www/~mkwst/no_crawl/docs/contentSecurityPolicy.html ) http://codereview.chromium.org/9212044/diff/9001/chrome/common/extensions/docs/static/contentSecurityPolicy.html File chrome/common/extensions/docs/static/contentSecurityPolicy.html (right): http://codereview.chromium.org/9212044/diff/9001/chrome/common/extensions/docs/static/contentSecurityPolicy.html#newcode6 ...
5 years, 6 months ago (2012-01-25 23:34:36 UTC) #5
mkearney
lgtm... For some reason the link to #syntax in the specification doesn't go to the ...
5 years, 6 months ago (2012-01-26 00:12:24 UTC) #6
abarth-chromium
On Wed, Jan 25, 2012 at 4:12 PM, <mkearney@google.com> wrote: > For some reason the ...
5 years, 6 months ago (2012-01-26 00:28:20 UTC) #7
Mike West
5 years, 5 months ago (2012-01-26 08:32:39 UTC) #8
On 2012/01/26 00:28:20, abarth wrote:
> On Wed, Jan 25, 2012 at 4:12 PM,  <mailto:mkearney@google.com> wrote:
> > For some reason the link to #syntax in the specification doesn't go to the
> > syntax location in the doc, even though that is the link when you manual go
> > to
> > it. The anchor in the specification must be a bit dodgy.
> 
> That's the script that makes the table of contents.  It's a W3C thing.

I'll leave it for now, might fiddle with it later.

Landing this regardless, just to make sure it makes the M18 cut.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 25c286973