Refactored thread pool

runtime/bin/thread_pool.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef BIN_THREAD_POOL_H_
 #define BIN_THREAD_POOL_H_
 
 #include "bin/builtin.h"
 #include "platform/globals.h"
 #include "platform/thread.h"
 
-typedef void* Task;
+class ThreadPool {
+ public:
+  typedef void* Task;
+  typedef void (*TaskHandler)(Task args);
+
+  ThreadPool(TaskHandler task_handler, int initial_size = 4)
+      : initial_size_(initial_size),
+        terminate_(false),
+        drain_(false),
+        size_(0),
+        head_(NULL),
+        tail_(NULL),
+        task_handler_(task_handler) {}
+
+  // Start the thread pool running.

[Mads Ager (google), 2012/01/24 12:29:39]

Remove ' running'

[Søren Gjesse, 2012/01/24 13:04:35]

Done.

+  void Start();
+  // Shutdown the thread pool. If drain is set to true all tasks

[Mads Ager (google), 2012/01/24 12:29:39]

I would put a blank line here.

[Søren Gjesse, 2012/01/24 13:04:35]

Done.

+  // pending in the queue will be processed. When this function
+  // returns all threads are terminated.
+  void Shutdown(bool drain = false);

[Mads Ager (google), 2012/01/24 12:29:39]

How about an enum instead of the bool: kDrain, kDoNotDrain?

[Søren Gjesse, 2012/01/24 13:04:35]

Done.

+
+  // Insert a new task into the thread pool. Returns true on success.
+  bool InsertTask(Task task);
+
+ private:
+  class TaskQueueEntry {
+   public:
+    explicit TaskQueueEntry(Task task) : task_(task), next_(NULL) {}
+
+    Task task() { return task_; }
+    TaskQueueEntry* next() { return next_; }
+    void set_next(TaskQueueEntry* value) { next_ = value; }
+
+   private:
+    Task task_;
+    TaskQueueEntry* next_;
+
+    DISALLOW_COPY_AND_ASSIGN(TaskQueueEntry);
+  };
 
 
-class TaskQueueEntry {
- public:
-  explicit TaskQueueEntry(Task task) : task_(task), next_(NULL) {}
-
-  Task task() { return task_; }
-
-  TaskQueueEntry* next() { return next_; }
-  void set_next(TaskQueueEntry* value) { next_ = value; }
-
- private:
-  Task task_;
-  TaskQueueEntry* next_;
-};
-
-
-// The task queue is a single linked list. Link direction is from tail
-// to head. New entried are inserted at the tail and entries are
-// removed from the head.
-class TaskQueue {
- public:
-  TaskQueue() : terminate_(false), head_(NULL), tail_(NULL) {}
-
-  void Insert(TaskQueueEntry* task);
-  TaskQueueEntry* Remove();
-  void Shutdown();
-
- private:
-  bool terminate_;
-  TaskQueueEntry* head_;
-  TaskQueueEntry* tail_;
-  dart::Monitor monitor_;
-
-  DISALLOW_COPY_AND_ASSIGN(TaskQueue);
-};
-
-
-class ThreadPool {
- public:
-  typedef void* (*TaskHandler)(void* args);
-
-  ThreadPool(TaskHandler task_handler, int initial_size = 4)
-      : terminate_(false),
-        size_(initial_size),
-        task_handler_(task_handler) {}
-
-  void Start();
-  void Shutdown();
-
-  void InsertTask(Task task);
-
+  TaskQueueEntry* WaitForTask();
   void ThreadTerminated();
 
- private:
-  Task WaitForTask();
-
   static void Main(uword args);
 
-  TaskQueue queue_;
-  // TODO(sgjesse): Move the monitor in TaskQueue to ThreadPool and
-  // obtain it for updating terminate_.
-  dart::Monitor monitor_;
-  bool terminate_;
-  int size_;  // Number of threads.
+  dart::Monitor monitor_;  // Monitor protecting all shared state.
+
+  int initial_size_;  // Initial number of threads to start.
+  bool terminate_;  // Set to true when the thread pool is terminating.
+  bool drain_;  // Process all queue entries before termination.
+  int size_;  // Current number of threads.
+
+  // The task queue is a single linked list. Link direction is from tail
+  // to head. New entried are inserted at the tail and entries are

[Mads Ager (google), 2012/01/24 12:29:39]

entries

[Søren Gjesse, 2012/01/24 13:04:35]

Done.

+  // removed from the head.
+  TaskQueueEntry* head_;
+  TaskQueueEntry* tail_;
   TaskHandler task_handler_;
 
   DISALLOW_COPY_AND_ASSIGN(ThreadPool);
 };
 
 #endif  // BIN_THREAD_POOL_H_