Make scoped dc objects smarter.

chrome/service/cloud_print/print_system_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/service/cloud_print/print_system.h"
 
 #include <objidl.h>
 #include <winspool.h>
 #include <xpsprint.h>
 
@@ skipping 388 matching lines @@
           DevMode pt_dev_mode;
           HRESULT hr = PrintTicketToDevMode(printer_name, print_ticket,
                                             &pt_dev_mode);
           if (FAILED(hr)) {
             NOTREACHED();
             return false;
           }
 
           HDC dc = CreateDC(L"WINSPOOL", UTF8ToWide(printer_name).c_str(),
                             NULL, pt_dev_mode.dm_);
-          if (!dc) {
-            NOTREACHED();
+          if (!dc)
             return false;
-          }
+
+          printer_dc_.Set(dc);
           hr = E_FAIL;
           DOCINFO di = {0};
           di.cbSize = sizeof(DOCINFO);
           std::wstring doc_name = UTF8ToWide(job_title);
           di.lpszDocName = doc_name.c_str();
           job_id_ = StartDoc(dc, &di);
           if (job_id_ <= 0)
             return false;
 
-          printer_dc_.Set(dc);
-          saved_dc_ = SaveDC(printer_dc_.Get());
+          saved_dc_ = SaveDC(printer_dc_.get());
           print_data_file_path_ = print_data_file_path;
           delegate_ = delegate;
           RenderNextPDFPages();
         } else if (print_data_mime_type == "application/vnd.ms-xpsdocument") {
           bool ret = PrintXPSDocument(printer_name,
                                       job_title,
                                       print_data_file_path,
                                       print_ticket);
           if (ret)
             delegate_ = delegate;
           return ret;
         } else {
           NOTREACHED();
           return false;
         }
         return true;
       }
 
       void PreparePageDCForPrinting(HDC, double scale_factor) {
-        SetGraphicsMode(printer_dc_.Get(), GM_ADVANCED);
+        SetGraphicsMode(printer_dc_.get(), GM_ADVANCED);
         // Setup the matrix to translate and scale to the right place. Take in
         // account the scale factor.
         // Note that the printing output is relative to printable area of
         // the page. That is 0,0 is offset by PHYSICALOFFSETX/Y from the page.
-        int offset_x = ::GetDeviceCaps(printer_dc_.Get(), PHYSICALOFFSETX);
-        int offset_y = ::GetDeviceCaps(printer_dc_.Get(), PHYSICALOFFSETY);
+        int offset_x = ::GetDeviceCaps(printer_dc_.get(), PHYSICALOFFSETX);
+        int offset_y = ::GetDeviceCaps(printer_dc_.get(), PHYSICALOFFSETY);
         XFORM xform = {0};
         xform.eDx = static_cast<float>(-offset_x);
         xform.eDy = static_cast<float>(-offset_y);
         xform.eM11 = xform.eM22 = 1.0 / scale_factor;
-        SetWorldTransform(printer_dc_.Get(), &xform);
+        SetWorldTransform(printer_dc_.get(), &xform);
       }
 
       // ServiceUtilityProcessHost::Client implementation.
       virtual void OnRenderPDFPagesToMetafileSucceeded(
           const printing::Emf& metafile,
           int highest_rendered_page_number,
           double scale_factor) OVERRIDE {
-        PreparePageDCForPrinting(printer_dc_.Get(), scale_factor);
-        metafile.SafePlayback(printer_dc_.Get());
+        PreparePageDCForPrinting(printer_dc_.get(), scale_factor);
+        metafile.SafePlayback(printer_dc_.get());
         bool done_printing = (highest_rendered_page_number !=
             last_page_printed_ + kPageCountPerBatch);
         last_page_printed_ = highest_rendered_page_number;
         if (done_printing)
           PrintJobDone();
         else
           RenderNextPDFPages();
       }
 
       // base::win::ObjectWatcher::Delegate implementation.
@@ skipping 33 matching lines @@
 
       virtual void OnChildDied() OVERRIDE {
         PrintJobDone();
       }
 
      private:
       void PrintJobDone() {
         // If there is no delegate, then there is nothing pending to process.
         if (!delegate_)
           return;
-        RestoreDC(printer_dc_.Get(), saved_dc_);
-        EndDoc(printer_dc_.Get());
+        RestoreDC(printer_dc_.get(), saved_dc_);
+        EndDoc(printer_dc_.get());
         if (-1 == last_page_printed_) {
           delegate_->OnJobSpoolFailed();
         } else {
           delegate_->OnJobSpoolSucceeded(job_id_);
         }
         delegate_ = NULL;
       }
 
       void RenderNextPDFPages() {
         printing::PageRange range;
         // Render 10 pages at a time.
         range.from = last_page_printed_ + 1;
         range.to = last_page_printed_ + kPageCountPerBatch;
         std::vector<printing::PageRange> page_ranges;
         page_ranges.push_back(range);
 
-        int printer_dpi = ::GetDeviceCaps(printer_dc_.Get(), LOGPIXELSX);
-        int dc_width = GetDeviceCaps(printer_dc_.Get(), PHYSICALWIDTH);
-        int dc_height = GetDeviceCaps(printer_dc_.Get(), PHYSICALHEIGHT);
+        int printer_dpi = ::GetDeviceCaps(printer_dc_.get(), LOGPIXELSX);
+        int dc_width = GetDeviceCaps(printer_dc_.get(), PHYSICALWIDTH);
+        int dc_height = GetDeviceCaps(printer_dc_.get(), PHYSICALHEIGHT);
         gfx::Rect render_area(0, 0, dc_width, dc_height);
         g_service_process->io_thread()->message_loop_proxy()->PostTask(
             FROM_HERE,
             base::Bind(&JobSpoolerWin::Core::RenderPDFPagesInSandbox, this,
                        print_data_file_path_, render_area, printer_dpi,
                        page_ranges, base::MessageLoopProxy::current()));
       }
 
       // Called on the service process IO thread.
       void RenderPDFPagesInSandbox(
@@ skipping 332 matching lines @@
   RpcStringFree(reinterpret_cast<RPC_WSTR *>(&proxy_id_as_string));
   return ret;
 }
 
 scoped_refptr<PrintSystem> PrintSystem::CreateInstance(
     const base::DictionaryValue* print_system_settings) {
   return new PrintSystemWin;
 }
 
 }  // namespace cloud_print