[App banners] Break apart AppBannerManager and AppBannerInfoBarDelegate

[App banners] Break apart AppBannerManager and AppBannerInfoBarDelegate

Moves a bunch of code from AppBannerManager into the new Java-side
AppBannerInfoBarDelegate.  This effectively makes it so that once
an app banner is created by the AppBannerManager the AppBannerInfoBar
is on its own for managing installation and blocking of the app it's
promoting.

Main changes include getting the WebContents and Tab from the infobar()
itself rather than relying on the AppBannerManager to provide it.

Further cleanup is required on the AppBannerManager to clean up the
creation pipline.

BUG=457414
Committed: https://crrev.com/c505bf51ad167592ea00ec51abc6eaa0399e318c
Cr-Commit-Position: refs/heads/master@{#316345}

[gone, 2015-02-13 03:06:12]

dfalcantara@chromium.org changed reviewers:
+ tedchoc@chromium.org

[gone, 2015-02-13 03:06:12]

Moves code around, mainly.

[Ted C, 2015-02-14 00:06:48]

lgtm

https://codereview.chromium.org/921073002/diff/1/chrome/browser/android/banne...
File chrome/browser/android/banners/app_banner_infobar_delegate.cc (right):

https://codereview.chromium.org/921073002/diff/1/chrome/browser/android/banne...
chrome/browser/android/banners/app_banner_infobar_delegate.cc:136: if (tab ==
nullptr) return true;
goes on the next line

https://codereview.chromium.org/921073002/diff/1/chrome/browser/android/banne...
chrome/browser/android/banners/app_banner_infobar_delegate.cc:183: return false;
I would early exit on this conditional at the top and then reduce the indent of
the rest of the function.

https://codereview.chromium.org/921073002/diff/1/chrome/browser/android/banne...
chrome/browser/android/banners/app_banner_infobar_delegate.cc:188: jobject obj,
not aligned correctly

https://codereview.chromium.org/921073002/diff/1/chrome/browser/android/banne...
chrome/browser/android/banners/app_banner_infobar_delegate.cc:211: jobject obj,
same here

[gone, 2015-02-14 00:15:37]

New patchsets have been uploaded after l-g-t-m from tedchoc@chromium.org

[gone, 2015-02-14 00:16:01]

https://chromiumcodereview.appspot.com/921073002/diff/1/chrome/browser/androi...
File chrome/browser/android/banners/app_banner_infobar_delegate.cc (right):

https://chromiumcodereview.appspot.com/921073002/diff/1/chrome/browser/androi...
chrome/browser/android/banners/app_banner_infobar_delegate.cc:136: if (tab ==
nullptr) return true;
On 2015/02/14 00:06:48, Ted C wrote:
> goes on the next line

Done.

https://chromiumcodereview.appspot.com/921073002/diff/1/chrome/browser/androi...
chrome/browser/android/banners/app_banner_infobar_delegate.cc:183: return false;
On 2015/02/14 00:06:48, Ted C wrote:
> I would early exit on this conditional at the top and then reduce the indent
of
> the rest of the function.

Done.

https://chromiumcodereview.appspot.com/921073002/diff/1/chrome/browser/androi...
chrome/browser/android/banners/app_banner_infobar_delegate.cc:188: jobject obj,
On 2015/02/14 00:06:48, Ted C wrote:
> not aligned correctly

Done.

https://chromiumcodereview.appspot.com/921073002/diff/1/chrome/browser/androi...
chrome/browser/android/banners/app_banner_infobar_delegate.cc:211: jobject obj,
On 2015/02/14 00:06:48, Ted C wrote:
> same here

Done.

[gone, 2015-02-14 00:38:52]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2015-02-14 00:39:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/921073002/20001

[commit-bot: I haz the power, 2015-02-14 00:58:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-14 01:00:34]

Patchset 2 (id:??) landed as
https://crrev.com/c505bf51ad167592ea00ec51abc6eaa0399e318c
Cr-Commit-Position: refs/heads/master@{#316345}