Issue 9204008: Fix a pair of utf-8 array lengths.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9204008: Fix a pair of utf-8 array lengths. (Closed)

Created:
8 years, 11 months ago by inferno

Modified:
8 years, 11 months ago

Reviewers:
Nico, Chris Evans, aarya

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Import UTF-8 fix from upstream: http://git.gnome.org/browse/libxml2/commit/?id=0795348aeb86648723bc391e4d02e20631c10bca BUG=110978 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118655

Patch Set 1 #

Total comments: 1

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	third_party/libxml/README.chromium	View		1 chunk	+1 line, -0 lines	1 comment	Download
	M	third_party/libxml/src/xmlsave.c	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Chris Evans

8 years, 11 months ago (2012-01-23 05:08:03 UTC) #3

LGTM with nit

http://chromiumcodereview.appspot.com/9204008/diff/1/third_party/libxml/READM...
File third_party/libxml/README.chromium (right):

http://chromiumcodereview.appspot.com/9204008/diff/1/third_party/libxml/READM...
third_party/libxml/README.chromium:23: - Import follow-on for above commit:
http://git.gnome.org/browse/libxml2/commit/?id=0795348aeb86648723bc391e4d02e2...
Again: it's not a follow-on.
Maybe "Import UTF-8 fix from upstream" ?

Expand Messages | Collapse Messages