Issue 9200006: Fix remote debugger crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9200006: Fix remote debugger crash. (Closed)

Created:
8 years, 11 months ago by Yang

Modified:
8 years, 11 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix remote debugger crash. Committed: https://code.google.com/p/v8/source/detail?r=10449

Patch Set 1 #

Total comments: 3

Patch Set 2 : . #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	src/d8.cc	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
	M	src/d8-debug.cc	View	1	2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

When having a first instance of d8 started as debugger agent (--debugger-agent) and a second ...

8 years, 11 months ago (2012-01-19 16:18:39 UTC) #1

Jakob Kummerow

8 years, 11 months ago (2012-01-19 16:23:12 UTC) #2

LGTM with nits.

http://codereview.chromium.org/9200006/diff/1/src/d8-debug.cc
File src/d8-debug.cc (right):

http://codereview.chromium.org/9200006/diff/1/src/d8-debug.cc#newcode1
src/d8-debug.cc:1: // Copyright 2011 the V8 project authors. All rights
reserved.
nit: 2012

http://codereview.chromium.org/9200006/diff/1/src/d8-debug.h
File src/d8-debug.h (right):

http://codereview.chromium.org/9200006/diff/1/src/d8-debug.h#newcode1
src/d8-debug.h:1: // Copyright 2008 the V8 project authors. All rights reserved.
nit: 2012

http://codereview.chromium.org/9200006/diff/1/src/d8-debug.h#newcode56
src/d8-debug.h:56: explicit RemoteDebugger(int port, Handle<Context> context)
nit: "explicit" is no longer necessary.

Expand Messages | Collapse Messages