Issue 91963003: Cleanup in the CallStubCompiler.

Issue 91963003: Cleanup in the CallStubCompiler. (Closed)

Created:
7 years ago by Toon Verwaest

Modified:
7 years ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Cleanup in the CallStubCompiler. BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18131

Patch Set 2 : ARM / ia32 port #

Patch Set 3 : Do not patch the global object if we did not keep the object around #

Patch Set 5 : Rebased / addressed feedback #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+263 lines, -377 lines)			Patch
M	src/arm/macro-assembler-arm.h	View	1 2 3 4	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	1 2 3 4	3 chunks	+15 lines, -2 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View	1 2 3 4	17 chunks	+42 lines, -116 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.h	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View	1 2 3 4	2 chunks	+13 lines, -6 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	1 2 3 4	16 chunks	+42 lines, -122 lines	0 comments	Download
M	src/stub-cache.h	View	1 2 3 4	3 chunks	+15 lines, -1 line	0 comments	Download
M	src/stub-cache.cc	View	1 2 3 4	1 chunk	+57 lines, -0 lines	0 comments	Download
M	src/x64/macro-assembler-x64.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1 2 3 4	2 chunks	+17 lines, -8 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1 2 3 4	16 chunks	+41 lines, -122 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Igor Sheludko

lgtm with nits. https://codereview.chromium.org/91963003/diff/60001/src/arm/stub-cache-arm.cc File src/arm/stub-cache-arm.cc (right): https://codereview.chromium.org/91963003/diff/60001/src/arm/stub-cache-arm.cc#newcode2104 src/arm/stub-cache-arm.cc:2104: GenerateCallFunction(Handle<Object>::null(), function); Consider introducing different function ...

7 years ago (2013-11-28 13:06:07 UTC) #2

Toon Verwaest

Addressed feedback. Landing. https://codereview.chromium.org/91963003/diff/60001/src/arm/stub-cache-arm.cc File src/arm/stub-cache-arm.cc (right): https://codereview.chromium.org/91963003/diff/60001/src/arm/stub-cache-arm.cc#newcode2104 src/arm/stub-cache-arm.cc:2104: GenerateCallFunction(Handle<Object>::null(), function); On 2013/11/28 13:06:08, Igor ...

7 years ago (2013-11-28 15:24:09 UTC) #3

Toon Verwaest

7 years ago (2013-11-28 15:26:14 UTC) #4

Message was sent while issue was closed.

Committed patchset #5 manually as r18131 (presubmit successful).

Expand Messages | Collapse Messages