Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 9196003: Fix responsiveness of high promotion mode heuristics. (Closed)

Created:
8 years, 11 months ago by Michael Starzinger
Modified:
8 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix responsiveness of high promotion mode heuristics. This changes the heuristics for the high promotion mode to be checked on all GCs (including scavenges), so that changes in the applications behavior are recognized earlier. It also fixes miscalculations in the survival counter and rate which caused heuristics to fail completely. R=vegorov@chromium.org BUG=v8:1899 Committed: https://code.google.com/p/v8/source/detail?r=10500

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment by Vyacheslav Egorov and fixed regression. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -34 lines) Patch
M src/heap.h View 1 4 chunks +19 lines, -5 lines 0 comments Download
M src/heap.cc View 1 6 chunks +45 lines, -29 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
8 years, 11 months ago (2012-01-16 09:53:53 UTC) #1
Vyacheslav Egorov (Chromium)
lgtm http://codereview.chromium.org/9196003/diff/1/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/9196003/diff/1/src/heap.cc#newcode5412 src/heap.cc:5412: intptr_t Heap::PromotedSpaceSize() { Size->SizeOfObjects for consistency.
8 years, 11 months ago (2012-01-16 12:36:11 UTC) #2
Michael Starzinger
Added new patch set. http://codereview.chromium.org/9196003/diff/1/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/9196003/diff/1/src/heap.cc#newcode5412 src/heap.cc:5412: intptr_t Heap::PromotedSpaceSize() { On 2012/01/16 ...
8 years, 11 months ago (2012-01-17 11:56:26 UTC) #3
Vyacheslav Egorov (Chromium)
8 years, 11 months ago (2012-01-17 11:58:00 UTC) #4
still lgtm

Powered by Google App Engine
This is Rietveld 408576698