Disable modal JavaScript dialogs for platform apps.

Disable modal JavaScript dialogs for platform apps.

- window.alert is silently ignored
- window.confirm returns false
- window.prompt returns null

BUG=none
TEST=PlatformAppBrowserTest.DisallowModalDialogs

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118874

[jstritar, 2012-01-19 20:20:40]

http://codereview.chromium.org/9195018/diff/2001/chrome/browser/extensions/pl...
File chrome/browser/extensions/platform_app_browsertest.cc (right):

http://codereview.chromium.org/9195018/diff/2001/chrome/browser/extensions/pl...
chrome/browser/extensions/platform_app_browsertest.cc:211:
ASSERT_TRUE(RunExtensionTest("platform_apps/modal_dialogs")) << message_;
I'll convert these to use RunExtensionSubtest and the same app, once one of the
CLs lands.

[Mihai Parparita -not on Chrome, 2012-01-21 00:00:39]

LGTM, thought the same comment as on http://codereview.chromium.org/9192021/
about doing tests from the launch page applies.

[jstritar, 2012-01-23 23:39:00]

Can you take a look at my changes to extension_apitest.*?

[Mihai Parparita -not on Chrome, 2012-01-24 01:59:14]

LGTM

https://chromiumcodereview.appspot.com/9195018/diff/10006/chrome/browser/exte...
File chrome/browser/extensions/extension_apitest.h (right):

https://chromiumcodereview.appspot.com/9195018/diff/10006/chrome/browser/exte...
chrome/browser/extensions/extension_apitest.h:139: kFlagEnableFileaccess = 1 <<
1,
Nit: Access should be capitalized.

https://chromiumcodereview.appspot.com/9195018/diff/10006/chrome/browser/exte...
File chrome/browser/extensions/platform_app_browsertest.cc (right):

https://chromiumcodereview.appspot.com/9195018/diff/10006/chrome/browser/exte...
chrome/browser/extensions/platform_app_browsertest.cc:61:
web_app::SetDisableShortcutCreationForTests(true);
You may want this for RunPlatformAppTest too (otherwise shortcuts will litter
the desktop when you run the test locally).

[commit-bot: I haz the power, 2012-01-24 16:49:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jstritar@chromium.org/9195018/13002

[commit-bot: I haz the power, 2012-01-24 17:51:16]

Try job failure for 9195018-13002 (retry) on linux_rel for step "update".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Step "update" is always a major failure.
Look at the try server FAQ for more details.