Issue 9195017: Generate stub-generator tests in the build directory, and do not commit them to repository.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9195017: Generate stub-generator tests in the build directory, and do not commit them to repository. (Closed)

Created:
8 years, 11 months ago by Bill Hesse

Modified:
8 years, 11 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org, Ben Laurie (Google), rchandia

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Generate stub-generator tests in the build directory, and do not commit them to repository. BUG=dart:260 TEST=stub-generator/MintMakerFullyIsolatedTest Committed: https://code.google.com/p/dart/source/detail?r=3491

Patch Set 1 #

Patch Set 2 : remove unneeded added parameter. #

Patch Set 3 : Add code for the unlikely case that these are the first tests run in a new checkout. #

Total comments: 2

Patch Set 4 : Fix spacing around + #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -3 lines)			Patch
M	tests/stub-generator/src/MintMakerFullyIsolatedTest.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/stub-generator/src/MintMakerPromiseWithStubsTest.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/stub-generator/test_config.dart	View	1 2 3	1 chunk	+14 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ricow1

8 years, 11 months ago (2012-01-23 13:31:01 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/9195017/diff/5/tests/stub-generator/te...
File tests/stub-generator/test_config.dart (right):

https://chromiumcodereview.appspot.com/9195017/diff/5/tests/stub-generator/te...
tests/stub-generator/test_config.dart:42: throw new Exception('Cannot find
$relativeImportPath from $resultPath');
actually we can't find relativeImportPath from neither resultPath or the orignal
resultsPath (i.e., without /generated_tests, but I don't know if this is
important here?

https://chromiumcodereview.appspot.com/9195017/diff/5/tests/stub-generator/te...
tests/stub-generator/test_config.dart:46: resultPath =
'$resultPath/${filename.substring(testNamePos+1)}';
space around +

Expand Messages | Collapse Messages